-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Ads blocker nag appears if changing menus fast #4402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I can't seem to reproduce this. Notifications and Contributions are different page loads. I wonder if there's a list you are subscribing to that blocks the nag. |
I can't replicate this in firefox 61.0.1 - Fedora 28. As David mention, notification/contributors load different pages |
I don't see how that is possible. The element isn't even on the DOM if you aren't using an ad blocker. |
I found another way to reproduce this issue in Chrome and Firefox (both without any ad blocker). Load any docs page (e.g. http://sphinx-autoapi.readthedocs.io/en/latest/) and press Escape before it loads completely. You will see the that nag. |
I can confirm that. |
Ok, thanks. This is good feedback. I was detecting an ad blocker by the ad request returning a 404. I guess I'll need a better method. I want to avoid something heavy. |
If you go to a page like this one https://oracle-cloud-infrastructure-python-sdk.readthedocs.io/en/latest/contributions.html and click fast between two different menu items (for example "Notifications" and "Contributions") you will see the nag that appears for a portion of second and then disappears.
I tried this in Firefox 61.0.1 (64-bits).
This is something not too much important but I wanted to report it anyway.
The text was updated successfully, but these errors were encountered: