Skip to content

Ads blocker nag appears if changing menus fast #4402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
humitos opened this issue Jul 18, 2018 · 7 comments
Closed

Ads blocker nag appears if changing menus fast #4402

humitos opened this issue Jul 18, 2018 · 7 comments
Assignees
Labels
Bug A bug

Comments

@humitos
Copy link
Member

humitos commented Jul 18, 2018

If you go to a page like this one https://oracle-cloud-infrastructure-python-sdk.readthedocs.io/en/latest/contributions.html and click fast between two different menu items (for example "Notifications" and "Contributions") you will see the nag that appears for a portion of second and then disappears.

I tried this in Firefox 61.0.1 (64-bits).

This is something not too much important but I wanted to report it anyway.

You can replicate this with and without an Ads blocker active.

@humitos humitos added the Bug A bug label Jul 18, 2018
@davidfischer davidfischer self-assigned this Jul 18, 2018
@davidfischer
Copy link
Contributor

I can't seem to reproduce this. Notifications and Contributions are different page loads. I wonder if there's a list you are subscribing to that blocks the nag.

@humitos
Copy link
Member Author

humitos commented Jul 18, 2018

It only happens in Firefox. I couldn't reproduce it in Chrome.

I wonder if there's a list you are subscribing to that blocks the nag.

This also happens here without running an Ad Blocker.

Just in case, by nag I'm referring to this green square:

captura de pantalla_2018-07-18_13-54-17

@stsewd
Copy link
Member

stsewd commented Jul 18, 2018

I can't replicate this in firefox 61.0.1 - Fedora 28. As David mention, notification/contributors load different pages

@davidfischer
Copy link
Contributor

This also happens here without running an Ad Blocker.

I don't see how that is possible. The element isn't even on the DOM if you aren't using an ad blocker.

@humitos
Copy link
Member Author

humitos commented Aug 5, 2018

I found another way to reproduce this issue in Chrome and Firefox (both without any ad blocker).

Load any docs page (e.g. http://sphinx-autoapi.readthedocs.io/en/latest/) and press Escape before it loads completely. You will see the that nag.

@stsewd
Copy link
Member

stsewd commented Aug 5, 2018

I can confirm that.

@davidfischer
Copy link
Contributor

Ok, thanks. This is good feedback. I was detecting an ad blocker by the ad request returning a 404. I guess I'll need a better method. I want to avoid something heavy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug
Projects
None yet
Development

No branches or pull requests

3 participants