-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Page redirect: Preserve query data in "PAGE" url #4384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Can you please share how you configured the redirection? I'll try to replicate this tomorrow. |
I don't see the redirect from the original issue. But I was able to reproduce a different bug. Are you sure you don't have an extra setup for redirecting from http://docs.platformio.org/page/projectconf/section_env_build.html?utm_source=platformio&utm_medium=piohome#build-flags ? The another bug: https://docs.platformio.org/en/latest/userguide/cmd_serialports.html redirects to https://docs.platformio.org/en/latest/userguide/cmd_device.html But https://docs.platformio.org/en/latest/userguide/cmd_serialports.html?foo=bar gives 404. |
You can reproduce this bug with any URL. For example, https://docs.readthedocs.io/page/webhooks.html?arg=test |
Sorry, I didn't know about the |
Ok, that's a different problem that the one I found before |
This is deployed and working! |
@stsewd thank you so much!!! 😊 |
Details
We use URL in PAGE format in different places. This allows us to control default LOCALIZATION and default VERSION (latest or specific). Also, we add some marketing data via QUERY PARAMETERS to URL for GA.
Example: http://docs.platformio.org/page/projectconf/section_env_build.html?utm_source=platformio&utm_medium=piohome#build-flags
Expected Result
Valid redirect should be: http://docs.platformio.org/en/latest/projectconf/section_env_build.html?utm_source=platformio&utm_medium=piohome#build-flags
Actual Result
http://docs.platformio.org/en/latest/projectconf/section_env_build.html#build-flags
The text was updated successfully, but these errors were encountered: