Skip to content

Page redirect: Preserve query data in "PAGE" url #4384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ivankravets opened this issue Jul 17, 2018 · 8 comments
Closed

Page redirect: Preserve query data in "PAGE" url #4384

ivankravets opened this issue Jul 17, 2018 · 8 comments
Assignees
Labels
Accepted Accepted issue on our roadmap Bug A bug

Comments

@ivankravets
Copy link

Details

We use URL in PAGE format in different places. This allows us to control default LOCALIZATION and default VERSION (latest or specific). Also, we add some marketing data via QUERY PARAMETERS to URL for GA.

Example: http://docs.platformio.org/page/projectconf/section_env_build.html?utm_source=platformio&utm_medium=piohome#build-flags

Expected Result

Valid redirect should be: http://docs.platformio.org/en/latest/projectconf/section_env_build.html?utm_source=platformio&utm_medium=piohome#build-flags

Actual Result

http://docs.platformio.org/en/latest/projectconf/section_env_build.html#build-flags

@RichardLitt RichardLitt added the Support Support question label Jul 18, 2018
@stsewd
Copy link
Member

stsewd commented Jan 8, 2019

Can you please share how you configured the redirection? I'll try to replicate this tomorrow.

@ivankravets
Copy link
Author

I have only these items:
screen shot 2019-01-08 at 17 03 32

@stsewd
Copy link
Member

stsewd commented Jan 8, 2019

I don't see the redirect from the original issue. But I was able to reproduce a different bug.

Are you sure you don't have an extra setup for redirecting from http://docs.platformio.org/page/projectconf/section_env_build.html?utm_source=platformio&utm_medium=piohome#build-flags ?

The another bug:

https://docs.platformio.org/en/latest/userguide/cmd_serialports.html redirects to https://docs.platformio.org/en/latest/userguide/cmd_device.html

But https://docs.platformio.org/en/latest/userguide/cmd_serialports.html?foo=bar gives 404.

@stsewd stsewd added Bug A bug and removed Support Support question labels Jan 8, 2019
@stsewd stsewd self-assigned this Jan 8, 2019
@ivankravets
Copy link
Author

Are you sure you don't have an extra setup for redirecting from

You can reproduce this bug with any URL. For example, https://docs.readthedocs.io/page/webhooks.html?arg=test

@stsewd
Copy link
Member

stsewd commented Jan 8, 2019

Sorry, I didn't know about the /page redirect.

@stsewd
Copy link
Member

stsewd commented Jan 8, 2019

@humitos humitos added the Accepted Accepted issue on our roadmap label Jan 9, 2019
@stsewd
Copy link
Member

stsewd commented Jan 24, 2019

This is deployed and working!

@ivankravets
Copy link
Author

@stsewd thank you so much!!! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Bug A bug
Projects
None yet
Development

No branches or pull requests

4 participants