Improve access to options of the configuration object #4346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

stsewd opened this issue Jul 9, 2018 · 1 comment

Labels

Improvement Needed: design decision

Milestone

YAML File Completion

Member

stsewd commented Jul 9, 2018

When refactoring the configuration object we found some inconsistencies in the names of the properties.

We can:

Treat the config as a dictionary
Rename some of the attributes now, so that they retain more contextual information -- ie, rename some of the nested options to python_*
Use a namedtuple or a package like bunch to create nested attribute accessor instances, instead of repeating the logic above for each accessor

Ref to #4298 (comment)

I think using a namedtuple would be enough for our use case.

stsewd added Improvement Needed: design decision labels

stsewd mentioned this issue

Refactor configuration object to class based #4298

Merged

agjohnson added this to the YAML File Completion milestone

Member Author

stsewd commented Aug 2, 2018

This was done in #4355 using name tuples

stsewd closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment