Skip to content

Outdated pip is causing builds with namespace packages to fail #4127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
theacodes opened this issue May 22, 2018 · 9 comments
Closed

Outdated pip is causing builds with namespace packages to fail #4127

theacodes opened this issue May 22, 2018 · 9 comments
Labels
Support Support question

Comments

@theacodes
Copy link

Recent failures:

Last successful build:
https://readthedocs.org/projects/google-cloud-python/builds/7225188/

It seems that this is due to pypa/setuptools#885, which indicates that pip and setuptools need to be updated in the baseline environment.

@theacodes
Copy link
Author

Also, this appears to be deterministic. Some of our builds pass, like this most recent one: https://readthedocs.org/projects/google-cloud-python/builds/7230426/

@stsewd stsewd added the Support Support question label May 22, 2018
@stsewd
Copy link
Member

stsewd commented May 22, 2018

The pip message is just a warning, so it shouldn't be the cause of the failure. I'm not sure why is this happening, I'll try to see if I can reproduce this on my local instance. Let us know if the build keeps failing.

@theacodes
Copy link
Author

The most recent few have failed. Here's one: https://readthedocs.org/projects/google-cloud-python/builds/7230941/

@theacodes
Copy link
Author

Seems like our recently builds today have consistently failed due to this: https://readthedocs.org/projects/google-cloud-python/builds/

Is there anything we can do to help? I'm happy to make the change to update pip/setuptools, I just don't know where to do it.

@stsewd
Copy link
Member

stsewd commented May 23, 2018

Maybe you can try wiping the environment, you can do this in the Versions section then Edit button.

What I can see is that the pip version comes from the docker image https://github.com/rtfd/readthedocs-docker-images/blob/9b0816d1b610373036ce16eb3653c99ca30e4207/Dockerfile#L92

So, the team needs to rebuild the image to get the latest versions, I think we should support upgrade pip before installing deps. I'm going to ask to the team.

@theacodes
Copy link
Author

Thanks, @stsewd! Clearing the environment seems to have helped.

Since we're using 'latest', it seems you'd need to rebuild the 3.x docker image from here.

@tswast
Copy link

tswast commented Jun 15, 2018

Adding pip_install: true to the config in pandas-gbq seemed to be the right fix for a similar error. googleapis/python-bigquery-pandas@ee9955f

@stsewd
Copy link
Member

stsewd commented Oct 31, 2018

Probably we can close this in favor of #4823

@stsewd
Copy link
Member

stsewd commented Nov 28, 2018

Closing in favor of #4823, but let me know if there are any other problems!

@stsewd stsewd closed this as completed Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Support Support question
Projects
None yet
Development

No branches or pull requests

3 participants