Skip to content

Project.documentation_type is auto #3980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
humitos opened this issue Apr 20, 2018 · 4 comments
Closed

Project.documentation_type is auto #3980

humitos opened this issue Apr 20, 2018 · 4 comments
Assignees
Labels
Bug A bug
Milestone

Comments

@humitos
Copy link
Member

humitos commented Apr 20, 2018

We have 528 projects with the Project.documentation_type set in auto and this value is not allowed in the code.

This value is used, for example at: https://github.com/rtfd/readthedocs.org/blob/be4ff5b9c4fb6f8c4f8b093e98a1359491a52b1f/readthedocs/doc_builder/python_environments.py#L276

But the dictionary used to get the proper builder class doesn't have the auto value and make the build to fail:

https://github.com/rtfd/readthedocs.org/blob/be4ff5b9c4fb6f8c4f8b093e98a1359491a52b1f/readthedocs/doc_builder/loader.py#L15-L32

We do have a way to protect ourselves for this, but this is still happening in production.

https://github.com/rtfd/readthedocs.org/blob/be4ff5b9c4fb6f8c4f8b093e98a1359491a52b1f/readthedocs/projects/tasks.py#L429-L431

I suppose that this is still happening because of #3946 isn't deployed yet.

This doesn't seem to be too important, but just filling this issue to keep track of this and make sure that it doesn't happen anymore after that PR is deployed.

Ref: https://sentry.io/read-the-docs/readthedocs-org/issues/472212666/events/latest/

@humitos humitos added the Bug A bug label Apr 20, 2018
@humitos humitos added this to the Build stability milestone Apr 20, 2018
@agjohnson
Copy link
Contributor

Sentry issue: READTHEDOCS-ORG-CWX

@agjohnson
Copy link
Contributor

Lets target this for this release, I'm seeing a lot of new errors around this project type, including ^

@agjohnson agjohnson modified the milestones: Build stability, 2.4 May 3, 2018
@humitos humitos self-assigned this May 3, 2018
@humitos
Copy link
Member Author

humitos commented May 10, 2018

To reproduce this, just change the Documentation Type to auto and the next build will fail.

@humitos
Copy link
Member Author

humitos commented May 10, 2018

it fails only in the immediate build, since it's automatically updated... but the build that updates it, fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug
Projects
None yet
Development

No branches or pull requests

2 participants