Skip to content

Show only relevant integrations and automate the setup on Admin #3936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
humitos opened this issue Apr 10, 2018 · 3 comments
Closed

Show only relevant integrations and automate the setup on Admin #3936

humitos opened this issue Apr 10, 2018 · 3 comments
Labels
Improvement Minor improvement to code Needed: design decision A core team decision is required
Milestone

Comments

@humitos
Copy link
Member

humitos commented Apr 10, 2018

When importing a project for a known service (Gitlab/Github/Bitbucket) the webhook/integration is configured automatically.

Then, going to Admin -> Integrations -> Add integration you have a dropdown to select between:

  • Github
  • Bitbucket
  • Gitlab
  • Generic

I'd say that we should only list only the relevant ones: Generic + the one of the known service for that Project.repo URL and I have an account of that service connected.

Also, in case the service connected (and project URL) is Gitlab, if I choose it that webhook option from the list it should be setup the webhook automatically instead of showing something like:

captura de pantalla_2018-04-10_16-42-56

Related to #3932 and also low priority.

@humitos humitos added the Improvement Minor improvement to code label Apr 10, 2018
@humitos humitos added this to the Admin UX milestone Apr 10, 2018
@stsewd
Copy link
Member

stsewd commented Apr 13, 2018

What about the people that want to add a webhook to a supported service without connecting their account? Also, wouldn't people think that rtd only supports that provider (the one that is connected to their account)?

@stale
Copy link

stale bot commented Jan 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Jan 10, 2019
@stsewd stsewd added Needed: design decision A core team decision is required and removed Status: stale Issue will be considered inactive soon labels Jan 10, 2019
@humitos
Copy link
Member Author

humitos commented Jan 23, 2019

What about the people that want to add a webhook to a supported service without connecting their account?

In this case (when the project was not imported from a known service) we should show all the options available.

Also, wouldn't people think that rtd only supports that provider (the one that is connected to their account)?

Mmm... This makes me think that even importing a using a connected account, I may want to "depend on another" repository (like Bitbucket) and trigger builds when something in that other repo has changed also.

I think this case it's kind of weird, though.

Anyway, we can close this issue as invalid for now.

@humitos humitos closed this as completed Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code Needed: design decision A core team decision is required
Projects
None yet
Development

No branches or pull requests

2 participants