Search result titles incorrectly include "(from project foo)"

[begriffs]

Expected Result

Search results should list the title of each page and a snippet.

Title One
some stuff in the page

Title Two
other stuff

Actual Result

Each title ends with a note "(from project foo)"

Title One (from project foo)
some stuff in the page

Title Two (from project foo)
other stuff

example

Cause

A recent commit to fix linter errors changed a != operator to !==: https://github.com/rtfd/readthedocs.org/blame/e923c0cdf7547e63b4d2a9ab2b5e69b527bb482b/readthedocs/core/static-src/core/js/doc-embed/search.js#L52-L57

if (fields.project !== project) {

Adding a breakpoint to that code, I saw that fields.project had the value ['foo'] while project was 'foo'. The old comparison treated them as equal, but the strict comparison knows that they differ.

/cc @bansalnitish

[stsewd]

Seems that the search functionality comes from a private repo https://github.com/rtfd/readthedocs.org/blob/d918a0fde1252ddbfa9c57dc6f196a207d65d9dc/readthedocs/restapi/urls.py#L95-L102.

[humitos]

@davidfischer seems that the linting PR around js code, breaks the search page results. It makes sense to me what @begriffs is saying here. Can you take a look at this?

[bansalnitish]

We can revert this case as well as mark the check as a warning instead of error for fixing this issue.

[humitos]

Why fields.project is ['foo'] instead of just 'foo' in first instance? Maybe that it's what needs to be changed, right?

[begriffs]

Any decision about what to do, i.e. revert the breaking change, or store as 'foo' rather than ['foo']? The former sounds more straightforward even though it seems like somewhat unclean code.

[stsewd]

Resolved on #4176