Skip to content

Clean up logging in project tasks #3665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
agjohnson opened this issue Feb 23, 2018 · 3 comments
Closed

Clean up logging in project tasks #3665

agjohnson opened this issue Feb 23, 2018 · 3 comments
Labels
Good First Issue Good for new contributors Improvement Minor improvement to code
Milestone
Refactoring

Comments

@agjohnson
Copy link
Contributor

Some of the classes are using a _log method that mangles the original caller for logging. These should call log.info directly.
@agjohnson agjohnson added Good First Issue Good for new contributors Improvement Minor improvement to code labels Feb 23, 2018
@agjohnson agjohnson added this to the Refactoring milestone Feb 23, 2018
@agjohnson agjohnson mentioned this issue Feb 23, 2018
Merged
@SanketDG SanketDG mentioned this issue Feb 25, 2018
Merged
@kchawla-pi
Copy link
Contributor

I would like to start on this. Any suggestions about where I should start, or anything I should know before I do?

@kchawla-pi
Copy link
Contributor

Seems PR #3677 fixes this. Does it?

@stsewd
Copy link
Member

stsewd commented Feb 25, 2018

@kchawla-pi yes, someone is already working on this issue.

@stsewd stsewd mentioned this issue Feb 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Good for new contributors Improvement Minor improvement to code
Projects
None yet
Milestone
Refactoring
Development

No branches or pull requests
3 participants
@agjohnson @stsewd @kchawla-pi