Skip to content

Conditionally do git submodule operations #3627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
agjohnson opened this issue Feb 16, 2018 · 0 comments
Closed

Conditionally do git submodule operations #3627

agjohnson opened this issue Feb 16, 2018 · 0 comments
Labels
Improvement Minor improvement to code
Milestone
Build output page

Comments

@agjohnson
Copy link
Contributor

We shouldn't be doing submodule operations on repositories that don't have submodules. We can check for this by determining if a repository has a .gitmodules file at the top level, and if not, we can skip these commands.

Raised in #3520 as we're storing all these as extraneous commands now.
@agjohnson agjohnson added the Improvement Minor improvement to code label Feb 16, 2018
@agjohnson agjohnson added this to the Build output page milestone Feb 16, 2018
@stsewd stsewd mentioned this issue Feb 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement Minor improvement to code
Projects
None yet
Milestone
Build output page
Development

No branches or pull requests
1 participant
@agjohnson