-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Missing i18n for footer and warning banner #3561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We could for instance parse the current url |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
We are already not using the banner by default on new projects. I think we should deprecate it, write docs suggesting https://github.com/humitos/sphinx-version-warning/ which is more configurable and finally remove our own banner. In case we need something extra, we can add those features to that extension which will be easier and we could support different setups instead of hardcode only one into our codebase. |
Yeah, we can ignore translating the warning banner for now, footer api still needs translation |
@stsewd We can use something like this to use django translation on the javascript code. but what needs to be translated on the footer API response? |
Details
The text displayed on the warning banner (when using an old version of the documentation) right now is hard coded on the js code.
https://github.com/rtfd/readthedocs.org/blob/b12e1885dc7f6da6b9719054e3654019b1e0fe65/readthedocs/core/static-src/core/js/doc-embed/version-compare.js#L18
Also the footer response from the API
https://github.com/rtfd/readthedocs.org/blob/master/readthedocs/restapi/templates/restapi/footer.html
Related comment #3547 (comment)
Expected Result
Warning message and footer are translated according to the current language of the docs.
Actual Result
The warning message and footer always display English text.
The text was updated successfully, but these errors were encountered: