-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Refactor BuildCommand and move outside doc_builder/ #3541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@humitos |
@dojutsu-user I don't remember exactly what I wanted to do, but it seems that we have some classes in I think there are some class names that don't really make sense because they have a I suggest you to read the PR linked and check if you find our a good refactor that can be applied to those classes. Otherwise, we could probably close the issue if you find out that it's obsolete and there are no good refactor here. |
@humitos |
A similar refactor was already done in #8815, so we can close this issue. |
Once #3520 got merged, we will end up with a couple of name that are inconsistent: https://github.com/rtfd/readthedocs.org/pull/3520/files/7f6c098983acb4bb3afc90e5c780af7dae9ec9d8#r163198277
In this case it should be named just
Command
and moved outdoc_builder/
. Besides a newBuildCommand
should exist that handles all the interaction with the Build itself and saving the command in the database.The idea is to find out more names like that one and refactor.
The text was updated successfully, but these errors were encountered: