View / Edit doesn't work

[sergei-bondarenko]

Details

• Project URL: https://github.com/HelloZeroNet/Documentation
• Build URL (if applicable): https://zeronet.readthedocs.io/en/latest/
• Read the Docs username (if applicable):

Expected Result

Click on v:latest in the right bottom corner -> On GitHub -> View / Edit.
It should open https://github.com/HelloZeroNet/Documentation/blob/master/docs/faq.md

Actual Result

404 Error.

P.S. Please don't close as a duplicate of #1422 or #1483, because it's not fixed.

[stsewd]

I think this issue is related to Mkdocs only, with sphinx works fine.

I was able to replicate this on my local instance, looks like the "Edit" url is taken from the mkdocs.yml file.

And also I noted that the footer url (from the floating v) is incorrect https://github.com/HelloZeroNet/Documentation/blob/master/home/docs/checkouts/readthedocs.org/user_builds/zeronet/checkouts/latest/docs/.md

[stsewd]

I think the top edit button is related to the theme (not sure, I was unable to find that code), the link on the footer is definitely related to the code base.

[stsewd]

After investigating more on this issue, I found you are using a custom theme (based on rtd). So, the real problem is on the templates, isn't a RTD bug.

For the "edit" link you need to update this file https://github.com/HelloZeroNet/Documentation/blob/master/readthedocs/breadcrumbs.html and inject the appropriates values (see http://www.mkdocs.org/about/release-notes/#context-variables).

About the second problem, when #3525 is merged you need to define the global variable READTHEDOCS_DATA['page'] (something like this https://github.com/HelloZeroNet/Documentation/blob/master/readthedocs/base.html#L25-L29, but must be after this lines https://github.com/HelloZeroNet/Documentation/blob/master/readthedocs/base.html#L38-L40). And everything would work properly.

[stsewd]

@grez911 I just see you deleted the whole custom theme, about the edit link please see #3991 (comment)

[stsewd]

Closing in favor of #3991