-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
allow specifying extras instead of requirements.txt #3484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Believe this will do it: http://docs.readthedocs.io/en/latest/yaml-config.html#python-extra-requirements |
That can work, I was thinking of trying out the YAML support. How does this work when building multiple versions? Does each tag need the YAML file or is it always pulled from master? I still think it would be convenient to have a web interface for this. |
Each tag will have its own yaml version file with its specific settings. As a general rule (although, it's not 100% strict yet), we are having "global settings" (those that affect all the builds/versions) under the web admin interface and "version specific settings" on the YAML file. |
That won't work for us. We want to build docs for old versions, but we've already released those tags, we don't usually go back and add new commits / releases just for docs. This is the same motivation for #3483. So I'd definitely like to see a global interface for this. |
I thought you weren't going to building off of tags but rather branches. Taking flask's branches for example, you would just have to commit a
|
Wasn't sure if it would be possible to do the branches, so wanted to cover the tag case as well. If what we want to do with branches will work, then I'm fine using the YAML config for specifying requirements. |
It is definitely possible to do branches. For Flask for example, you'd go to https://readthedocs.org/projects/flask/versions/ and set the branches you want to build. There are still some other complications building Flask's docs which I'm working on. Flask's |
We discussed this yesterday and since it may take us some time to do it as a general solution, we wanted to have a quicker and simple solution to don't break on this case. @davidfischer opened the PR #4349 that will make your project to not interferes with the RTD context data. Once merged, we will need to know all the projects that use the pallets theme to add this feature to them. |
Actually, Flask's conf shouldn't be setting |
I think the short term fix is #4349. The longer term fix will be to implement https://docs.readthedocs.io/en/latest/design/theme-context.html |
That's fine, I can make that work. |
Our projects rely on
setup.py
instead ofrequirements.txt
for specifying requirements. I'd like to be able to add anextras_require
named "docs" and tell RTD about it so that it can dopip install .[docs]
when building, instead of creating a separatedocs-require.txt
file.The text was updated successfully, but these errors were encountered: