Skip to content

Port over JSON builder avoidance from pydoc #3393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
agjohnson opened this issue Dec 11, 2017 · 2 comments
Closed

Port over JSON builder avoidance from pydoc #3393

agjohnson opened this issue Dec 11, 2017 · 2 comments
Labels
Improvement Minor improvement to code Priority: high High priority

Comments

@agjohnson
Copy link
Contributor

Pydoc gets around this by building the JSON output into Sphinx. Port this over.

@agjohnson agjohnson added the Improvement Minor improvement to code label Dec 11, 2017
@ericholscher
Copy link
Member

ericholscher commented Mar 12, 2018

The existing logic is:

The quick version is:

  • Currently we run an entire second build to output JSON from Sphinx, in order to support search
  • We should output the JSON as an artifact of the build process
  • This might hit some edge cases in building people's docs, but it would save around 20-25% of our build resources, which would be a huge win for us

There will likely be some issues with weird encoding and other things, but I'd really like this to get some focus here soon.

@ericholscher
Copy link
Member

@safwanrahman you might find this and the attached PR's interesting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code Priority: high High priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants