Skip to content

Close up /build endpoint #3130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks
agjohnson opened this issue Sep 28, 2017 · 0 comments
Closed
3 tasks

Close up /build endpoint #3130

agjohnson opened this issue Sep 28, 2017 · 0 comments
Labels
Improvement Minor improvement to code

Comments

@agjohnson
Copy link
Contributor

agjohnson commented Sep 28, 2017 •
edited by ericholscher
Loading

The /build endpoint should be deprecated. Anyone can abuse this endpoint and trigger builds across any number of projects. We now have authenticated build endpoints that users should be using.

Steps to deprecation

  • Find users legitimately using the endpoint (Add a build_source on builds, so we can track it)
  • Feature flag these users as allowed
  • Remove feature for all other projects and all newly imported projects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement Minor improvement to code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@agjohnson