Skip to content

Find pattern for removing options from project admin #2666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
agjohnson opened this issue Feb 24, 2017 · 1 comment
Closed

Find pattern for removing options from project admin #2666

agjohnson opened this issue Feb 24, 2017 · 1 comment
Labels
Improvement Minor improvement to code Needed: design decision A core team decision is required

Comments

@agjohnson
Copy link
Contributor

Many of the project admin options should be moved to our .readthedocs.yml file. We'll want a pattern for deprecating the option in our admin. Perhaps we implement a feature flag type model that flags new users as not having access to the model field. I'm not sure what the model forms would look like in this case, but might have to be dynamic and on __init__ remove these fields?

Some options here:

Neither project mentions ripping up forms to do feature flagging specifically.

Refs #2663

@agjohnson agjohnson added Improvement Minor improvement to code Needed: design decision A core team decision is required labels Feb 24, 2017
@agjohnson
Copy link
Contributor Author

readthedocs.projects.models.Feature does this! Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code Needed: design decision A core team decision is required
Projects
None yet
Development

No branches or pull requests

1 participant