-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Support 'base' in ConfigWrapper and Sphinx backend #2646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@agjohnson I want to work on this issue. |
@stsewd Would you be able to help with this? |
@RichardLitt @Jigar3 I'm not familiar with the https://github.com/rtfd/readthedocs-build project, but what I understand this would be a step for moving the build process to the other library. I'm going to take a look to the other project on the next days, so hope to be more helpful then. |
@RichardLitt well now I think I have some more experience with the other project (sorry for taking a long time). @Jigar3 I recommend you reading the spec of the yaml file here https://github.com/rtfd/readthedocs-build/blob/master/docs/spec.rst, also https://docs.readthedocs.io/en/latest/yaml-config.html (#3685 contains more accurate docs) so you have a little more of context of what this issue is about. From the spec:
This is what the issue is about, respecting the |
@Jigar3 are you still interested or working on this issue? |
I think we can close this in favor of #4354 |
Closing as this isn't on our current schema, and we have the new |
As per the spec for https://github.com/rtfd/readthedocs-build, we should support the 'base' configuration element. This logic would need to be moved from the project model and into the sphinx backend, but this makes more sense anyways.
The text was updated successfully, but these errors were encountered: