Skip to content

Search results are dropping the .html extension #2596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
julie-sullivan opened this issue Jan 18, 2017 · 10 comments
Closed

Search results are dropping the .html extension #2596

julie-sullivan opened this issue Jan 18, 2017 · 10 comments
Labels
Bug A bug

Comments

@julie-sullivan
Copy link

julie-sullivan commented Jan 18, 2017

Details

Expected Result

  1. Do a keyword search, e.g. using the string "portal".
  2. Get four results back
  3. All four links in search results work correctly, including the one titled "linking in to your mine":

http://intermine.readthedocs.io/en/latest/webapp/linking-in/index.html?highlight=portal

Actual Result

  1. Do a keyword search, e.g. using the string "portal".
  2. Get four results back
  3. Three links in the search results work correctly, except for the one titled "linking in to your mine":

http://intermine.readthedocs.io/en/latest/webapp/linking-in/index?highlight=portal

  • If you append .html, that URL works
  • If you build the docs locally, all URLs are always correct. The .html is not dropped.
@humitos
Copy link
Member

humitos commented May 28, 2017

Related to #2829

@stsewd
Copy link
Member

stsewd commented Mar 31, 2018

@stsewd
Copy link
Member

stsewd commented Mar 31, 2018

I can't replicate this on my local instance, I don't have elastic search set up, but the search works on your project, so, I think there is an overlapping with elastic search and the theme or extension that provide the search to your docs.

@RichardLitt RichardLitt added the Needed: replication Bug replication is required label Apr 2, 2018
@stale
Copy link

stale bot commented Jan 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Jan 10, 2019
@humitos
Copy link
Member

humitos commented Jan 10, 2019

I was able to replicate this issue just by going to

https://intermine.readthedocs.io/en/latest/search/?q=portal&check_keywords=yes&area=default

and the first link displayed is this one: https://intermine.readthedocs.io/en/latest/webapp/linking-in/index?highlight=portal and should be this one https://intermine.readthedocs.io/en/latest/webapp/linking-in/index.html?highlight=portal (note the .html on it)

This is a bug that will probably be fixed when all the work already done around search has been deployed.

@stale stale bot removed the Status: stale Issue will be considered inactive soon label Jan 10, 2019
@humitos humitos added Accepted Accepted issue on our roadmap and removed Needed: replication Bug replication is required Accepted Accepted issue on our roadmap labels Jan 10, 2019
@humitos
Copy link
Member

humitos commented Jan 10, 2019

We can revisit it one some time after deploying new changes for ES. Hopefully, stale bot will remind us :)

@stale
Copy link

stale bot commented Feb 24, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Feb 24, 2019
@stsewd
Copy link
Member

stsewd commented Feb 24, 2019

This issue looks like #5254, I'm not able to replicate it anymore. I guess we don't use the resolver anymore in the new search.

@stale stale bot removed the Status: stale Issue will be considered inactive soon label Feb 24, 2019
@humitos
Copy link
Member

humitos commented Feb 25, 2019

I'm closing this one since we can't replicate it anymore. Feel free to reopen if you still have this issue.

@humitos humitos closed this as completed Feb 25, 2019
@julie-sullivan
Copy link
Author

thank you!! Yes, it seems to be working now. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug
Projects
None yet
Development

No branches or pull requests

4 participants