Skip to content

Support elastic search 2.x+ #2539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
agjohnson opened this issue Dec 1, 2016 · 3 comments
Closed

Support elastic search 2.x+ #2539

agjohnson opened this issue Dec 1, 2016 · 3 comments
Labels
Improvement Minor improvement to code

Comments

@agjohnson
Copy link
Contributor

Elastic search 2.x is not supported currently, because of conflicting mappings:

Conflicting field mappings: Mapping for field page:id conflicts with: project:id. Check parameters: index, type

This should be resolved to support 2.x upgrades

@agjohnson agjohnson added the Improvement Minor improvement to code label Dec 1, 2016
@humitos
Copy link
Member

humitos commented May 28, 2017

@agjohnson can you give more details on this?

Today, the latest version of elasticsearch is 5.4.0 (https://www.elastic.co/downloads/elasticsearch) and it's the same version for python wrapper (https://pypi.python.org/pypi/elasticsearch/5.4.0).

I tried upgrading both and I found minor incompatibilities in the python code. I changed this

from elasticsearch.helpers import bulk_index

for

from elasticsearch.helpers import bulk

but there are problems regarding the API since it's incompatible and needs to be updated. In particular the body creation at https://github.com/humitos/readthedocs.org/blob/a0a29e8bbb454d9296b91492d31ecbee396fe1fa/readthedocs/search/lib.py#L17-L39 and the parsing response at https://github.com/humitos/readthedocs.org/blob/a0a29e8bbb454d9296b91492d31ecbee396fe1fa/readthedocs/search/views.py#L47-L58

@humitos
Copy link
Member

humitos commented May 28, 2017

On the other hand, I think that we are not using pyelasticsearch at all from https://github.com/humitos/readthedocs.org/blob/a0a29e8bbb454d9296b91492d31ecbee396fe1fa/requirements/pip.txt#L40

@humitos
Copy link
Member

humitos commented Dec 28, 2017

Closing this one in favor of #3373

@humitos humitos closed this as completed Dec 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code
Projects
None yet
Development

No branches or pull requests

2 participants