Skip to content

Git clone failures are not detailed enough #2496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benjaoming opened this issue Nov 14, 2016 · 1 comment
Closed

Git clone failures are not detailed enough #2496

benjaoming opened this issue Nov 14, 2016 · 1 comment

Comments

@benjaoming
Copy link
Contributor

Details

Expected Result

I have long been baffled by why our builds have stopped working all by themselves. The output of the build failure is almost entirely useless.. all I can say is that cloning doesn't work on RTD, but of course works fine on my local machine :)

Actual Result

I've tried developing a RTD locally and found that the actual problem IS within our repo because of a wild .gitmodules which someone has put in the repo, and now RTD has started using submodules.

So the actual problem IMO is that error messages don't indicate the actual issue.

I'm PR'ing this now!

@benjaoming benjaoming changed the title Git clone failures are not detailed Git clone failures are not detailed enough Nov 14, 2016
@agjohnson
Copy link
Contributor

Closing this here. I opened another issue, #2512, as i think we missed some review feedback on the PR. A more complete fix will require altering our exception handling anyways, so there is a larger chunk of work there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants