Skip to content

Git backend transforming tags/branches incorrectly #1989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
agjohnson opened this issue Feb 11, 2016 · 3 comments
Closed

Git backend transforming tags/branches incorrectly #1989

agjohnson opened this issue Feb 11, 2016 · 3 comments
Assignees
Labels
Bug A bug Needed: design decision A core team decision is required

Comments

@agjohnson
Copy link
Contributor

I had thought that the refactor to version slugs had unified our slugging for VCS versions, but it seems the Git backend is still performing transforms on these names. Is there a reason for this?

For instance, a repository with a tag of "release/foobar" becomes just "foobar" at:
https://github.com/rtfd/readthedocs.org/blob/master/readthedocs/vcs_support/backends/git.py#L113

Shouldn't the VersionSlugField be handling this now?

@agjohnson agjohnson added Needed: design decision A core team decision is required Bug A bug labels Feb 11, 2016
@humitos
Copy link
Member

humitos commented Dec 18, 2017

@agjohnson following you example, what should be the correct slug generated, release-foobar?

@agjohnson
Copy link
Contributor Author

I think that's fine. The bigger question is why this isn't already happening I suppose. The logic should exist already

@humitos
Copy link
Member

humitos commented Jan 29, 2018

There are more discussion in the PR, but the thing is that we were transforming the slug and the verbose_name and we need to transform the slug only.

verbose_name is used for the "Edit on Github" link for example and GH wants the full name in the URL, even with the / on it (release/foobar)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug Needed: design decision A core team decision is required
Projects
None yet
Development

No branches or pull requests

2 participants