Skip to content

Refactor oauth utils and managers #1696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
agjohnson opened this issue Sep 25, 2015 · 0 comments · Fixed by #1850
Closed

Refactor oauth utils and managers #1696

agjohnson opened this issue Sep 25, 2015 · 0 comments · Fixed by #1850
Assignees
Labels
Improvement Minor improvement to code

Comments

@agjohnson
Copy link
Contributor

In dealing with #1695, it became apparent that the oauth utils and manager creation method could be refactored a good deal. Thoughts here:

  • Make provider classes that organize code and reduce duplication of codes
  • Breakup up sync functions into digestable methods on provider classes
  • Managers rely on providers for breaking down json responses, instead of splitting up code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant