Skip to content

Respond to linting errors and enable CI linting #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
agjohnson opened this issue Jul 22, 2015 · 2 comments
Closed

Respond to linting errors and enable CI linting #1471

agjohnson opened this issue Jul 22, 2015 · 2 comments
Labels
Feature New feature Good First Issue Good for new contributors Sprintable Small enough to sprint on
Milestone

Comments

@agjohnson
Copy link
Contributor

With #1450, we will be getting back to performing linting on contributed code. Because we haven't been linting code for a while, there are a lot of outstanding issues that need to be resolved before we can start using linting as a metric for code quality.

The ultimate goal of this ticket is to ensure that we can run automated linting via Travis, against all applications except projects/ and builds/. Any pull requests that address linting errors should reference this ticket for tracking.

When contributing linting clean up pull requests, keep pull requests reasonably small, don't address multiple applications needlessly. Grouping cleanup efforts across applications like this will more likely create conflicts that will slow down clean up efforts.

Linting will be run from Tox, clean up efforts only need to address the problems in those errors. See http://docs.readthedocs.org/en/latest/tests.html for more information on our test suite.

refs #1424

@gregmuellegger
Copy link
Contributor

See #1522

@gregmuellegger
Copy link
Contributor

Was fixed with the merge of #1522.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature Good First Issue Good for new contributors Sprintable Small enough to sprint on
Projects
None yet
Development

No branches or pull requests

2 participants