Skip to content

Project version slugging need to respect slashes #1176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
agjohnson opened this issue Mar 3, 2015 · 9 comments
Closed

Project version slugging need to respect slashes #1176

agjohnson opened this issue Mar 3, 2015 · 9 comments
Assignees

Comments

@agjohnson
Copy link
Contributor

Project versions with slashes don't match the regex for reverse path resolution:

NoReverseMatch: Reverse for 'project_version_detail' with arguments '(u'cffi', u'the_drow/ensured-that-enums-cannot-be-declared-wi-1410868467138')' and keyword arguments '{}' not found. 1 pattern(s) tried: ['dashboard/(?P<project_slug>[-\\w]+)/version/(?P<version_slug>[-\\w.]+)/$']

Version slugging or url pattern matching should respect extra characters

@funsim
Copy link

funsim commented Mar 19, 2015

Im hitting this issue as well.

@arigo
Copy link

arigo commented May 18, 2015

Can you at least ignore such branch names and let the page go through? I'm quite annoyed because I cannot access this versions page to create a "release-0.9" version, at https://readthedocs.org/dashboard/cffi/versions/ ...

@arigo
Copy link

arigo commented May 19, 2015

To work around the blocker, I removed the whole project, and set up a different project going to a different repo. For now I manually copy just the doc changes to this new repo, with no strange branch name.

@gregmuellegger
Copy link
Contributor

I started working on this in #1362

@gregmuellegger
Copy link
Contributor

This was fixed with the merge of #1362

@arigo
Copy link

arigo commented Jul 2, 2015

I don't know if it is the same issue, but I still get the "ascii whale" picture with "Fail. Check back in a bit!" if I log in (arigo) and try to go to the page https://readthedocs.org/projects/pypy/versions/ . If you want to look inside the logs, I tried to reload several times in the seconds before I posted this.

@gregmuellegger
Copy link
Contributor

It is a slightly different one. But just so slightly. I fixed it in #1396 (and checked in a local installation with the pypy project that it fixes the issue). The problem were uppercase letters in the branch name, in your case it was SomeChar-charclass. The issue should be finally resolved when the PR gets deployed.

@gregmuellegger gregmuellegger reopened this Jul 2, 2015
@gregmuellegger gregmuellegger self-assigned this Jul 2, 2015
@gregmuellegger
Copy link
Contributor

@arigo is this fixed for you now?

@arigo
Copy link

arigo commented Jul 9, 2015

Yes, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants