Skip to content

Version in ReadTheDocs retains the tags commit ID preventing a rebuild based on the updated commit for the TAG #10838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
uhurusurfa opened this issue Oct 18, 2023 · 5 comments · Fixed by #10879
Labels
Accepted Accepted issue on our roadmap Bug A bug

Comments

@uhurusurfa
Copy link

Details

Expected Result

*When the tag associate with a version in ReadTheDocs is updated to a new commit and I go to ReadThgeDocs UI and force a rerun iof the failed build, it should fetch the latest code from the git repository using the tag rather than the commit number it retrieved first time round.

Actual Result

The build simply uses the same commit so there is no change to the outcome of the build.

Suggested feature or behaviour

Either fetch the code based on the tag or provide a way to delete the version in ReadTheDocs so that it can be properly rebuilt using the updarted commit.

@stsewd
Copy link
Member

stsewd commented Oct 18, 2023

Hi, this is a known problem, currently you'll need to trigger two builds, the first build will update the commit tag, and the second build will actually build the tag with the new commit. I agree that we should just use the tag instead of the commit here.

@stsewd stsewd added Bug A bug Accepted Accepted issue on our roadmap labels Oct 18, 2023
@stsewd stsewd reopened this Nov 2, 2023
@stsewd
Copy link
Member

stsewd commented Nov 2, 2023

We had to revert the PR #10887.

@sachin-suresh-rapyuta
Copy link

sachin-suresh-rapyuta commented Apr 12, 2024

Hi guys, Just wanted to check if there is any progress on this issue.

I updated the commit for this version 3.2.0-rc11.

image

Maybe I got it wrong, I tried to trigger this build twice for this version- 3.2.0-rc11 on RTD. The commit is still - b3cefebd which does not seem to update.

@stsewd
Copy link
Member

stsewd commented Apr 15, 2024

@sachin-suresh-rapyuta you can try triggering a build on a different version for it to update the other versions.

@davidism
Copy link

I just ran into this with MarkupSafe. I have a 1.1.x tag pointing to the last commit on the 1.1.x line. I had to update that to address some docs theme changes. Force pushing the new tag did trigger a build of the 1.1.x version of the docs. But it checks out the commit by id rather than tag, and that id is still the commit the tag previously pointed to. https://app.readthedocs.org/projects/markupsafe/builds/25970674/ Triggering a build for a different version, then triggering a build for 1.1.x, did fix it, but this is very confusing. Why did the push trigger a build that didn't update the id?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Bug A bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants