-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Upgrade rust build environment to 1.70 #10466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for reporting this. It's good to know that people are using Rust on our platform 👍 I'll try to find some time to prioritize this work. |
I think it is a good strategy to offer Rust support as a increasing number of python packages make use of it. Thank you for looking into this |
Rust 1.70 is available already. Can you confirm it's working for you? I did a quick test at https://readthedocs.org/projects/test-builds/builds/21135832/ and it worked for me. |
Yes, I can confirm it works - Thanks a lot ! |
What's the problem this feature will solve?
The most recent currently available version of rust on RTD is 1.64, rust itself is at 1.70. In most cases 1.64 is fine, but there is a increasing amount of crates requiring newer features of the language, so repositories using those can not be build on RTD.
The case I was running into this was when building https://github.com/nmandery/h3ronpy :
The build log output was
Describe the solution you'd like
Having a more recent rust version available would be great. 1.65 would seemingly be sufficient for this issue, but upgrading directly to 1.70 would certainly be more sustainable.
I saw #9692 and while I am not too familiar with how RTD works, I could try to submit a PR according to whats done there.
Alternative solutions
I am not aware of any good workarounds.
Additional context
The text was updated successfully, but these errors were encountered: