-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Config: Add explicit options to exclude a project from search #10092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
(this issue is added to summarize how a potential less-hackish solution to a support issue could be fixed) |
We have a feature flag for this, and this is only relevant for sphinx projects, we inject our custom search there by default. For mkdocs and docs built with build.commands, we don't inject our custom search, users need to do that themselves (this can be by installing our sphinx search extension).
Not sure if I understand this one, is this "dashboard search" https://readthedocs.org/search/?q=project:docs%20 you are referring to? |
I've been confused since I received that question about disabling server side search on MkDocs. I get now that it doesn't exist and you've done tonnes of work to plan it for MkDocs 👍
I hope it will be relevant to have configuration for this. IIRC, we want to stop using feature flags for configuration.
Maybe there's another term? Dashboard search is searches performed by the user while logged in on their own projects or projects that they have special access to on Read the Docs 4 Business. I added |
This issue seems related to #7217 I think that users don't really want to disable the "server side search", what they want to disable is the "integration Read the Docs injects on their documentation and go back to the doctool original search". Now, that can be done by disabling the search addon. I don't see too much value on disabling them from dashboard search, so I don't think we need a config for that. In any case, feel free to re-open if you consider. |
Some documentation projects want to have their own search in place of server side search. This means that none of the search features should be active on the project. Some projects can want a mix of this.
This might be a bit complicated, but there are several cases to cover for:
Only d) would benefit from disabling indexing, but it's not necessary given that there are explicit options for in-doc, dashboard and global search inclusion.
Currently, we can remove all pages from search indexing:
search.ignore: all
is perhaps better thansearch.ignore: '*'
.. but it doesn't really matter, since this does not work for a), b) nor c).Here's a rough sketch of how that could look:
The text was updated successfully, but these errors were encountered: