Skip to content

PR build link points to build page instead of artifact #10018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
benjaoming opened this issue Feb 13, 2023 · 0 comments · Fixed by #10085
Closed

PR build link points to build page instead of artifact #10018

benjaoming opened this issue Feb 13, 2023 · 0 comments · Fixed by #10085
Assignees
@ericholscher
Labels
Accepted Accepted issue on our roadmap Bug A bug

Comments

@benjaoming
Copy link
Contributor

Details

This started behaving differently after last week's deploy, likely related to: #9807

An example:

Notice that the build URLs in the builds of the PR do not point to latest deploy https://readthedocs-blog--207.org.readthedocs.build/

Another example:
django-wiki/django-wiki#1272

Expected Result

When the build succeeds, the PR status link on GitHub would point directly to the PR version.
@benjaoming benjaoming added Bug A bug Accepted Accepted issue on our roadmap labels Feb 13, 2023
@github-project-automation github-project-automation bot moved this to Planned in 📍Roadmap Feb 13, 2023
@ericholscher ericholscher moved this from Planned to In progress in 📍Roadmap Feb 23, 2023
@ericholscher ericholscher mentioned this issue Feb 28, 2023
Merged
@humitos humitos mentioned this issue Mar 1, 2023
Merged
@benjaoming benjaoming moved this from In progress to Needs review in 📍Roadmap Apr 22, 2023
@github-project-automation github-project-automation bot moved this from Needs review to Done in 📍Roadmap May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericholscher ericholscher

Labels
Accepted Accepted issue on our roadmap Bug A bug
Projects
📍Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix checking of PR status readthedocs/readthedocs.org
2 participants
@ericholscher @benjaoming