Merge pull request #5944 from readthedocs/fix-invalid-highlight-access

Properly return None when there's no highlight on a hit.

Author: ericholscher

readthedocs/search/api.py

@@ -62,12 +62,14 @@ def get_inner_hits(self, obj):
 
     def _get_inner_hits_highlights(self, hit):
         """Removes new lines from highlight and log it."""
-        highlight_dict = utils._remove_newlines_from_dict(
-            hit.highlight.to_dict()
-        )
-
-        log.debug('API Search highlight: %s', pformat(highlight_dict))
-        return highlight_dict
+        if hasattr(hit, 'highlight'):
+            highlight_dict = utils._remove_newlines_from_dict(
+                hit.highlight.to_dict()
+            )
+
+            log.debug('API Search highlight: %s', pformat(highlight_dict))
+            return highlight_dict
+        return {}
 
 
 class PageSearchAPIView(generics.ListAPIView):