Merge pull request #5803 from rtfd/davidfischer/apiv3-skip-expensive-all-query

Optimize requests to APIv3

Author: davidfischer

readthedocs/api/v3/mixins.py

@@ -81,17 +81,12 @@ def get_queryset(self):
         4. raise a ``NotFound`` exception otherwise
         """
 
-        # NOTE: ``super().get_queryset`` produces the filter by ``NestedViewSetMixin``
-        # we need to have defined the class attribute as ``queryset = Model.objects.all()``
+        # We need to have defined the class attribute as ``queryset = Model.objects.all()``
         queryset = super().get_queryset()
 
         # Detail requests are public
         if self.detail:
             return self.detail_objects(queryset, self.request.user)
 
         # List view are only allowed if user is owner of parent project
-        listing_objects = self.listing_objects(queryset, self.request.user)
-        if listing_objects:
-            return listing_objects
-
-        raise NotFound
+        return self.listing_objects(queryset, self.request.user)