Raise RepositoryError onf failed checkout

Author: stsewd

readthedocs/projects/exceptions.py

@@ -47,6 +47,10 @@ class RepositoryError(BuildEnvironmentError):
         'You can not have two versions with the name latest or stable.'
     )
 
+    FAILED_TO_CHECKOUT = _(
+        'Failed to checkout revision: {}'
+    )
+
     def get_default_message(self):
         if settings.ALLOW_PRIVATE_REPOS:
             return self.PRIVATE_ALLOWED

readthedocs/rtd_tests/tests/test_backend.py

@@ -120,6 +120,17 @@ def test_git_update_and_checkout(self):
         self.assertEqual(code, 0)
         self.assertTrue(exists(repo.working_dir))
 
+    def test_git_checkout_invalid_revision(self):
+        repo = self.project.vcs_repo()
+        repo.update()
+        version = 'invalid-revision'
+        with self.assertRaises(RepositoryError) as e:
+            repo.checkout(version)
+        self.assertEqual(
+            str(e.exception),
+            RepositoryError.FAILED_TO_CHECKOUT.format(version)
+        )
+
     def test_git_tags(self):
         repo_path = self.project.repo
         create_git_tag(repo_path, 'v01')

readthedocs/vcs_support/backends/git.py

@@ -147,7 +147,9 @@ def checkout_revision(self, revision=None):
 
         code, out, err = self.run('git', 'checkout', '--force', revision)
         if code != 0:
-            log.warning("Failed to checkout revision '%s': %s", revision, code)
+            raise RepositoryError(
+                RepositoryError.FAILED_TO_CHECKOUT.format(revision)
+            )
         return [code, out, err]
 
     def clone(self):