Clean up promo JS

Author: ericholscher

readthedocs/core/static-src/core/js/readthedocs-doc-embed.js

@@ -59,7 +59,7 @@ $(document).ready(function () {
 
             // Show promo selectively
             if (data.promo && build.show_promo()) {
-                var promo = sponsorship.Promo.from_variant([
+                var promo = sponsorship.Promo.from_variants([
                   id=data.promo_data.id,
                   text=data.promo_data.text,
                   image=data.promo_data.image,

readthedocs/core/static/core/js/readthedocs-doc-embed.js

@@ -98,7 +98,7 @@ $(document).ready(function () {
 
             // Show promo selectively
             if (data.promo && build.show_promo()) {
-                var promo = sponsorship.Promo.from_variant([
+                var promo = sponsorship.Promo.from_variants([
                   id=data.promo_data.id,
                   text=data.promo_data.text,
                   image=data.promo_data.image,

readthedocs/restapi/views/footer_views.py

@@ -61,6 +61,8 @@ def footer_html(request):
         show_promo = False
 
     promo_obj = SupporterPromo.objects.filter(live=True, display_type='doc').order_by('?').first()
+    if not promo_obj:
+        show_promo = False
 
     context = Context({
         'project': project,