Address review feedback

Author: ericholscher

readthedocs/search/api.py

@@ -62,7 +62,7 @@ def get_queryset(self):
         # Validate all the required params are there
         self.validate_query_params()
         query = self.request.query_params.get('q', '')
-        kwargs = {'filter_user': False}
+        kwargs = {'filter_by_user': False}
         kwargs['projects_list'] = [p.slug for p in self.get_all_projects()]
         kwargs['versions_list'] = self.request.query_params.get('version')
         user = self.request.user

readthedocs/search/faceted_search.py

@@ -21,8 +21,7 @@ def __init__(self, user, **kwargs):
             but is used on the .com
         """
         self.user = user
-        if 'filter_user' in kwargs:
-            self.filter_user = kwargs.pop('filter_user')
+        self.filter_by_user = kwargs.pop('filter_by_user')
         super().__init__(**kwargs)
 
     def query(self, search, query):

readthedocs/search/utils.py

@@ -24,12 +24,12 @@ def get_project_list_or_404(project_slug, user, version_slug=None):
     """
     # Support private projects with public versions
     project_list = []
-    main_project = get_object_or_404(Project.objects.all(), slug=project_slug)
+    main_project = get_object_or_404(Project, slug=project_slug)
     subprojects = Project.objects.filter(superprojects__parent_id=main_project.id)
     for project in list(subprojects) + [main_project]:
         version = Version.objects.public(user).filter(project__slug=project.slug, slug=version_slug)
-        if version.count():
-            project_list.append(version[0].project)
+        if version.exists():
+            project_list.append(version.first().project)
     return project_list