Only show promo if it exists

ericholscher · ericholscher · commit fa635d3b2cfd · 2015-07-07T11:03:05.000-07:00
diff --git a/readthedocs/restapi/views/footer_views.py b/readthedocs/restapi/views/footer_views.py
@@ -88,6 +88,7 @@ def footer_html(request):
         'version_active': version.active,
         'version_supported': version.supported,
         'promo': show_promo,
-        'promo_data': promo_obj.as_dict(),
     }
+    if show_promo and promo_obj:
+        resp_data['promo_data'] = promo_obj.as_dict()
     return Response(resp_data)

Original file line number	Diff line number	Diff line change
`@@ -88,6 +88,7 @@ def footer_html(request):`
`88`	`88`	`'version_active': version.active,`
`89`	`89`	`'version_supported': version.supported,`
`90`	`90`	`'promo': show_promo,`
`91`		`- 'promo_data': promo_obj.as_dict(),`
`92`	`91`	`}`
	`92`	`+ if show_promo and promo_obj:`
	`93`	`+ resp_data['promo_data'] = promo_obj.as_dict()`
`93`	`94`	`return Response(resp_data)`