Support ads on pallets themes

Author: davidfischer

readthedocs/core/static-src/core/js/doc-embed/constants.js

@@ -3,7 +3,6 @@
 var exports = {
     THEME_RTD: 'sphinx_rtd_theme',
     THEME_ALABASTER: 'alabaster',
-    THEME_CELERY: 'sphinx_celery',
     THEME_MKDOCS_RTD: 'readthedocs',
 
     DEFAULT_PROMO_PRIORITY: 5,
@@ -15,7 +14,6 @@ var exports = {
 exports.PROMO_SUPPORTED_THEMES = [
     exports.THEME_RTD,
     exports.THEME_ALABASTER,
-    exports.THEME_CELERY
 ];
 
 exports.PROMO_TYPES = {

readthedocs/core/static-src/core/js/doc-embed/rtd-data.js

@@ -11,6 +11,11 @@ var configMethods = {
         return this.get_theme_name() === constants.THEME_RTD;
     },
 
+    is_alabaster_theme: function () {
+        // Returns true for Alabaster-like themes (eg. flask, celery)
+        return this.get_theme_name() === constants.THEME_ALABASTER;
+    },
+
     theme_supports_promo: function () {
         return constants.PROMO_SUPPORTED_THEMES.indexOf(this.get_theme_name()) > -1;
     },
@@ -24,14 +29,15 @@ var configMethods = {
     },
 
     get_theme_name: function () {
-        // Crappy heuristic, but people change the theme name on us.  So we have to
-        // do some duck typing.
-        if (this.theme !== constants.THEME_RTD) {
+        // Crappy heuristic, but people change the theme name on us.
+        // So we have to do some duck typing.
+        if (this.theme !== constants.THEME_RTD && this.theme !== constants.THEME_ALABASTER) {
             if (this.theme === constants.THEME_MKDOCS_RTD) {
                 return constants.THEME_RTD;
-            }
-            if ($('div.rst-other-versions').length === 1) {
+            } else if ($('div.rst-other-versions').length === 1) {
                 return constants.THEME_RTD;
+            } else if ($('div.sphinxsidebar > div.sphinxsidebarwrapper').length === 1) {
+                return constants.THEME_ALABASTER;
             }
         }
         return this.theme;

readthedocs/core/static-src/core/js/doc-embed/sponsorship.js

@@ -24,8 +24,7 @@ function create_sidebar_placement() {
     } else if (rtd.is_rtd_theme()) {
         selector = 'nav.wy-nav-side > div.wy-side-scroll';
         class_name = 'ethical-rtd';
-    } else if (rtd.get_theme_name() === constants.THEME_ALABASTER ||
-               rtd.get_theme_name() === constants.THEME_CELERY) {
+    } else if (rtd.is_alabaster_theme()) {
         selector = 'div.sphinxsidebar > div.sphinxsidebarwrapper';
         class_name = 'ethical-alabaster';
     }
@@ -66,8 +65,7 @@ function create_footer_placement() {
     if (rtd.is_rtd_theme()) {
         selector = $('<div />').insertAfter('footer hr');
         class_name = 'ethical-rtd';
-    } else if (rtd.get_theme_name() === constants.THEME_ALABASTER ||
-               rtd.get_theme_name() === constants.THEME_CELERY) {
+    } else if (rtd.is_alabaster_theme()) {
         selector = 'div.bodywrapper .body';
         class_name = 'ethical-alabaster';
     }