Check if filters.project is empty

Author: stsewd

readthedocs/search/api.py

@@ -120,6 +120,10 @@ def get_queryset(self):
         kwargs = {'filter_by_user': False, 'filters': {}}
         kwargs['filters']['project'] = [p.slug for p in self.get_all_projects()]
         kwargs['filters']['version'] = self._get_version().slug
+        # Check to avoid searching all projects in case project is empty.
+        if not kwargs['filters']['project']:
+            log.info("Unable to find a project to search")
+            return HTMLFile.objects.none()
         user = self.request.user
         queryset = PageSearch(
             query=query, user=user, **kwargs

readthedocs/search/tests/test_api.py

@@ -1,4 +1,5 @@
 import re
+from unittest import mock
 
 import pytest
 from django.urls import reverse
@@ -7,6 +8,7 @@
 from readthedocs.builds.models import Version
 from readthedocs.projects.constants import PUBLIC
 from readthedocs.projects.models import HTMLFile, Project
+from readthedocs.search.api import PageSearchAPIView
 from readthedocs.search.documents import PageDocument
 from readthedocs.search.tests.utils import (
     DOMAIN_FIELDS,
@@ -263,3 +265,20 @@ def test_doc_search_unexisting_version(self, api_client, project):
         }
         resp = self.get_search(api_client, search_params)
         assert resp.status_code == 404
+
+    @mock.patch.object(PageSearchAPIView, 'get_all_projects', list)
+    def test_get_all_projects_returns_empty_results(self, api_client, project):
+        """If there is a case where `get_all_projects` returns empty, we could be querying all projects."""
+
+        # `documentation` word is present both in `kuma` and `docs` files
+        # and not in `pipeline`, so search with this phrase but filter through project
+        search_params = {
+            'q': 'documentation',
+            'project': 'docs',
+            'version': 'latest'
+        }
+        resp = self.get_search(api_client, search_params)
+        assert resp.status_code == 200
+
+        data = resp.data['results']
+        assert len(data) == 0