Lint

Author: ericholscher

readthedocs/builds/syncers.py

@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 """
 Classes to copy files between build and web servers.
 
@@ -174,7 +172,8 @@ def copy(cls, path, target, host, is_file=False, **kwargs):  # pylint: disable=a
 class SelectiveStorageRemotePuller(RemotePuller):
 
     """
-    Exactly like RemotePuller except that certain files are copied via Django's storage system
+    Exactly like RemotePuller except that certain files are copied via Django's
+    storage system.
 
     If a file with extensions specified by ``extensions`` is copied, it will be copied to storage
     and the original is removed.
@@ -187,7 +186,7 @@ class SelectiveStorageRemotePuller(RemotePuller):
     @classmethod
     def get_storage_path(cls, path):
         """
-        Gets the path to the file within the storage engine
+        Gets the path to the file within the storage engine.
 
         For example, if the path was $MEDIA_ROOT/pdfs/latest.pdf
          the storage_path is 'pdfs/latest.pdf'
@@ -213,7 +212,7 @@ def copy(cls, path, target, host, is_file=False, **kwargs):  # pylint: disable=a
 
             if is_file and os.path.exists(target) and \
                     any([target.lower().endswith(ext) for ext in cls.extensions]):
-                log.info("Selective Copy %s to media storage", target)
+                log.info('Selective Copy %s to media storage', target)
 
                 storage_path = cls.get_storage_path(target)
 

readthedocs/projects/models.py

@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 """Project models."""
 
 import fnmatch
@@ -514,7 +512,7 @@ def get_subproject_urls(self):
 
     def get_storage_path(self, type_, version_slug=LATEST):
         """
-        Get a path to a build artifact for use with Django's storage system
+        Get a path to a build artifact for use with Django's storage system.
 
         :param type_: Media content type, ie - 'pdf', 'htmlzip'
         :param version_slug: Project version slug for lookup
@@ -748,20 +746,32 @@ def has_aliases(self):
     def has_pdf(self, version_slug=LATEST):
         if not self.enable_pdf_build:
             return False
-        path = self.get_production_media_path(type_='pdf', version_slug=version_slug)
-        storage_path = self.get_storage_path(type_='pdf', version_slug=version_slug)
+        path = self.get_production_media_path(
+            type_='pdf', version_slug=version_slug
+        )
+        storage_path = self.get_storage_path(
+            type_='pdf', version_slug=version_slug
+        )
         return os.path.exists(path) or storage.exists(storage_path)
 
     def has_epub(self, version_slug=LATEST):
         if not self.enable_epub_build:
             return False
-        path = self.get_production_media_path(type_='epub', version_slug=version_slug)
-        storage_path = self.get_storage_path(type_='epub', version_slug=version_slug)
+        path = self.get_production_media_path(
+            type_='epub', version_slug=version_slug
+        )
+        storage_path = self.get_storage_path(
+            type_='epub', version_slug=version_slug
+        )
         return os.path.exists(path) or storage.exists(storage_path)
 
     def has_htmlzip(self, version_slug=LATEST):
-        path = self.get_production_media_path(type_='htmlzip', version_slug=version_slug)
-        storage_path = self.get_storage_path(type_='htmlzip', version_slug=version_slug)
+        path = self.get_production_media_path(
+            type_='htmlzip', version_slug=version_slug
+        )
+        storage_path = self.get_storage_path(
+            type_='htmlzip', version_slug=version_slug
+        )
         return os.path.exists(path) or storage.exists(storage_path)
 
     @property

readthedocs/projects/tasks.py

@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 """
 Tasks related to projects.
 
@@ -854,7 +852,8 @@ def build_docs_html(self):
                 type='app',
                 task=move_files,
                 args=[
-                    self.version.pk, socket.gethostname(), self.config.doctype
+                    self.version.pk,
+                    socket.gethostname(), self.config.doctype
                 ],
                 kwargs=dict(html=True),
             )
@@ -926,15 +925,8 @@ def is_type_sphinx(self):
 # Web tasks
 @app.task(queue='web')
 def sync_files(
-        project_pk,
-        version_pk,
-        doctype,
-        hostname=None,
-        html=False,
-        localmedia=False,
-        search=False,
-        pdf=False,
-        epub=False,
+        project_pk, version_pk, doctype, hostname=None, html=False,
+        localmedia=False, search=False, pdf=False, epub=False,
         delete_unsynced_media=True
 ):
     """

readthedocs/projects/views/public.py

@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 """Public project views."""
 
 import json
@@ -15,7 +13,7 @@
 from django.contrib.auth.models import User
 from django.core.cache import cache
 from django.core.files.storage import get_storage_class
-from django.http import Http404, HttpResponse, HttpResponseRedirect
+from django.http import HttpResponse, HttpResponseRedirect
 from django.shortcuts import get_object_or_404, render
 from django.urls import reverse
 from django.views.decorators.cache import never_cache
@@ -208,7 +206,9 @@ def project_download_media(request, project_slug, type_, version_slug):
     )
     privacy_level = getattr(settings, 'DEFAULT_PRIVACY_LEVEL', 'public')
     if privacy_level == 'public' or settings.DEBUG:
-        storage_path = version.project.get_storage_path(type_=type_, version_slug=version_slug)
+        storage_path = version.project.get_storage_path(
+            type_=type_, version_slug=version_slug
+        )
         if storage.exists(storage_path):
             return HttpResponseRedirect(storage.url(storage_path))
 

readthedocs/rtd_tests/tests/test_project.py

@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 import datetime
 import json
 
@@ -253,10 +252,8 @@ def test_user_can_not_add_other_user_project_as_translation(self):
         self.assertIsNone(project_b.main_language_project)
 
     def test_previous_users_can_list_and_delete_translations_not_owner(self):
-        """
-        Test to make sure that previous users can list and delete
-        projects where they aren't owners.
-        """
+        """Test to make sure that previous users can list and delete projects
+        where they aren't owners."""
         user_a = User.objects.get(username='eric')
         project_a = get(
             Project, users=[user_a],

readthedocs/rtd_tests/tests/test_project_views.py

@@ -1,8 +1,7 @@
-# -*- coding: utf-8 -*-
 
 from datetime import timedelta
 
-from mock import patch
+from allauth.account.models import EmailAddress
 from django.contrib.auth.models import User
 from django.contrib.messages import constants as message_const
 from django.http.response import HttpResponseRedirect
@@ -11,7 +10,7 @@
 from django.utils import timezone
 from django.views.generic.base import ContextMixin
 from django_dynamic_fixture import get, new
-from allauth.account.models import EmailAddress
+from mock import patch
 
 from readthedocs.builds.constants import LATEST
 from readthedocs.builds.models import Build, Version