Skip to content

Commit f7d2101

Browse files
authored
Hosting: Don't check for superprojects on subprojects (#11683)
1 parent 4e1251b commit f7d2101

File tree

2 files changed

+17
-1
lines changed

2 files changed

+17
-1
lines changed

readthedocs/proxito/tests/test_hosting.py

+16
Original file line numberDiff line numberDiff line change
@@ -863,6 +863,22 @@ def test_number_of_queries_url_subproject(self):
863863
)
864864
assert r.status_code == 200
865865

866+
# Test parent project has fewer queries
867+
with self.assertNumQueries(21):
868+
r = self.client.get(
869+
reverse("proxito_readthedocs_docs_addons"),
870+
{
871+
"url": "https://project.dev.readthedocs.io/en/latest/",
872+
"client-version": "0.6.0",
873+
"api-version": "1.0.0",
874+
},
875+
secure=True,
876+
headers={
877+
"host": "project.dev.readthedocs.io",
878+
},
879+
)
880+
assert r.status_code == 200
881+
866882
def test_number_of_queries_url_translations(self):
867883
# Create multiple translations to be shown in the flyout
868884
for language in ["ja", "es", "ru", "pt-br"]:

readthedocs/proxito/views/hosting.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -568,7 +568,7 @@ def _v1(self, project, version, build, filename, url, request):
568568
f"subprojects:{project.slug}/{version.slug}",
569569
]
570570
)
571-
if project.superprojects.exists():
571+
elif project.superprojects.exists():
572572
superproject = project.superprojects.first().parent
573573
data["addons"]["search"]["filters"].append(
574574
[

0 commit comments

Comments
 (0)