Version sync: exclude external versions when deleting (#7742)

We weren't hitting this before bc we were excluding active versions.
But now, external versions can also be inactive.

Author: stsewd

readthedocs/api/v2/utils.py

@@ -7,6 +7,7 @@
 
 from readthedocs.builds.constants import (
     BRANCH,
+    INTERNAL,
     LATEST,
     LATEST_VERBOSE_NAME,
     NON_REPOSITORY_VERSIONS,
@@ -176,7 +177,7 @@ def _get_deleted_versions_qs(project, version_data):
     ]
 
     to_delete_qs = (
-        project.versions
+        project.versions(manager=INTERNAL)
         .exclude(uploaded=True)
         .exclude(slug__in=NON_REPOSITORY_VERSIONS)
     )

readthedocs/rtd_tests/tests/test_sync_versions.py

@@ -7,7 +7,7 @@
 from django.urls import reverse
 from django_dynamic_fixture import get
 
-from readthedocs.builds.constants import BRANCH, LATEST, STABLE, TAG
+from readthedocs.builds.constants import BRANCH, EXTERNAL, LATEST, STABLE, TAG
 from readthedocs.builds.models import (
     RegexAutomationRule,
     Version,
@@ -183,6 +183,15 @@ def test_delete_version(self):
             verbose_name='0.8.3',
             active=False,
         )
+
+        Version.objects.create(
+            project=self.pip,
+            identifier='external',
+            verbose_name='external',
+            type=EXTERNAL,
+            active=False,
+        )
+
         self.pip.update_stable_version()
 
         version_post_data = {
@@ -209,6 +218,11 @@ def test_delete_version(self):
             Version.objects.filter(slug='0.8.3').exists(),
         )
 
+        # The inactive external version isn't deleted
+        self.assertTrue(
+            Version.objects.filter(slug='external').exists(),
+        )
+
     def test_machine_attr_when_user_define_stable_tag_and_delete_it(self):
         """
         The user creates a tag named ``stable`` on an existing repo,