Build: fix API call to version.patch() (#10175)

stsewd · web-flow · commit eadf6ac6dc6a · 2023-03-22T10:58:08.000-05:00
The attribute in the serializer isn't declared as allow_null=True,
so the call to patch fails for projects that aren't using this new
feature.

This also fixes tests on .com.
diff --git a/readthedocs/api/v2/serializers.py b/readthedocs/api/v2/serializers.py
@@ -126,7 +126,7 @@ class VersionAdminSerializer(VersionSerializer):
 
     project = ProjectAdminSerializer()
     canonical_url = serializers.SerializerMethodField()
-    build_data = serializers.JSONField(required=False, write_only=True)
+    build_data = serializers.JSONField(required=False, write_only=True, allow_null=True)
 
     def get_canonical_url(self, obj):
         return obj.project.get_docs_url(
diff --git a/readthedocs/proxito/tests/test_hosting.py b/readthedocs/proxito/tests/test_hosting.py
@@ -16,6 +16,7 @@
 @override_settings(
     PUBLIC_DOMAIN="dev.readthedocs.io",
     PUBLIC_DOMAIN_USES_HTTPS=True,
+    GLOBAL_ANALYTICS_CODE=None,
 )
 @pytest.mark.proxito
 class TestReadTheDocsConfigJson(TestCase):

Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,7 @@`
`16`	`16`	`@override_settings(`
`17`	`17`	`PUBLIC_DOMAIN="dev.readthedocs.io",`
`18`	`18`	`PUBLIC_DOMAIN_USES_HTTPS=True,`
	`19`	`+ GLOBAL_ANALYTICS_CODE=None,`
`19`	`20`	`)`
`20`	`21`	`@pytest.mark.proxito`
`21`	`22`	`class TestReadTheDocsConfigJson(TestCase):`