Reduce unused params.

In several cases, we can use the provided `request` rather than access `self`
(which could make these functions easier to test in isolation). In others, the
unused args could be folded into an unnamed kwarg param.

Author: CM Lubinski

readthedocs/restapi/views/model_views.py

@@ -50,7 +50,7 @@ def get_queryset(self):
     def valid_versions(self, request, **kwargs):
         """Maintain state of versions that are wanted."""
         project = get_object_or_404(
-            Project.objects.api(self.request.user), pk=kwargs['pk'])
+            Project.objects.api(request.user), pk=kwargs['pk'])
         if not project.num_major or not project.num_minor or not project.num_point:
             return Response(
                 {'error': 'Project does not support point version control'},
@@ -65,7 +65,7 @@ def valid_versions(self, request, **kwargs):
         })
 
     @detail_route()
-    def translations(self, request, pk, **kwargs):
+    def translations(self, _, **__):
         translations = self.get_object().translations.all()
         return Response({
             'translations': ProjectSerializer(translations, many=True).data
@@ -74,7 +74,7 @@ def translations(self, request, pk, **kwargs):
     @detail_route()
     def subprojects(self, request, **kwargs):
         project = get_object_or_404(
-            Project.objects.api(self.request.user), pk=kwargs['pk'])
+            Project.objects.api(request.user), pk=kwargs['pk'])
         rels = project.subprojects.all()
         children = [rel.child for rel in rels]
         return Response({
@@ -84,7 +84,7 @@ def subprojects(self, request, **kwargs):
     @decorators.detail_route(permission_classes=[permissions.IsAdminUser])
     def token(self, request, **kwargs):
         project = get_object_or_404(
-            Project.objects.api(self.request.user), pk=kwargs['pk'])
+            Project.objects.api(request.user), pk=kwargs['pk'])
         token = GitHubService.get_token_for_project(project, force_local=True)
         return Response({
             'token': token
@@ -93,7 +93,7 @@ def token(self, request, **kwargs):
     @decorators.detail_route()
     def canonical_url(self, request, **kwargs):
         project = get_object_or_404(
-            Project.objects.api(self.request.user), pk=kwargs['pk'])
+            Project.objects.api(request.user), pk=kwargs['pk'])
         return Response({
             'url': project.get_docs_url()
         })
@@ -106,7 +106,7 @@ def sync_versions(self, request, **kwargs):
         Returns the identifiers for the versions that have been deleted.
         """
         project = get_object_or_404(
-            Project.objects.api(self.request.user), pk=kwargs['pk'])
+            Project.objects.api(request.user), pk=kwargs['pk'])
 
         # If the currently highest non-prerelease version is active, then make
         # the new latest version active as well.