Adding RTD prefix for docker only and changing the variable names to pass all the tests

Author: Iamshankhadeep

readthedocs/config/config.py

@@ -151,7 +151,7 @@ class BuildConfigBase:
         'submodules',
     ]
 
-    default_build_image = settings.DOCKER_DEFAULT_VERSION
+    default_build_image = settings.RTD_DOCKER_DEFAULT_VERSION
 
     version = None
 
@@ -266,7 +266,7 @@ def valid_build_images(self):
         ``readthedocs/build`` part) plus ``stable`` and ``latest``.
         """
         images = {'stable', 'latest'}
-        for k in settings.DOCKER_IMAGE_SETTINGS:
+        for k in settings.RTD_DOCKER_IMAGE_SETTINGS:
             _, version = k.split(':')
             if re.fullmatch(r'^[\d\.]+$', version):
                 images.add(version)
@@ -282,12 +282,12 @@ def get_valid_python_versions_for_image(self, build_image):
         Returns supported versions for the ``DOCKER_DEFAULT_VERSION`` if not
         ``build_image`` found.
         """
-        if build_image not in settings.DOCKER_IMAGE_SETTINGS:
+        if build_image not in settings.RTD_DOCKER_IMAGE_SETTINGS:
             build_image = '{}:{}'.format(
-                settings.DOCKER_DEFAULT_IMAGE,
+                settings.RTD_DOCKER_DEFAULT_IMAGE,
                 self.default_build_image,
             )
-        return settings.DOCKER_IMAGE_SETTINGS[build_image]['python']['supported_versions']
+        return settings.RTD_DOCKER_IMAGE_SETTINGS[build_image]['python']['supported_versions']
 
     def as_dict(self):
         config = {}
@@ -324,7 +324,7 @@ def get_valid_python_versions(self):
             return self.env_config['python']['supported_versions']
         except (KeyError, TypeError):
             versions = set()
-            for _, options in settings.DOCKER_IMAGE_SETTINGS.items():
+            for _, options in settings.RTD_DOCKER_IMAGE_SETTINGS.items():
                 versions = versions.union(
                     options['python']['supported_versions']
                 )
@@ -379,7 +379,7 @@ def validate_build(self):
         if 'build' in self.env_config:
             build = self.env_config['build'].copy()
         else:
-            build = {'image': settings.DOCKER_IMAGE}
+            build = {'image': settings.RTD_DOCKER_IMAGE}
 
         # User specified
         if 'build' in self.raw_config:
@@ -393,12 +393,12 @@ def validate_build(self):
             if ':' not in build['image']:
                 # Prepend proper image name to user's image name
                 build['image'] = '{}:{}'.format(
-                    settings.DOCKER_DEFAULT_IMAGE,
+                    settings.RTD_DOCKER_DEFAULT_IMAGE,
                     build['image'],
                 )
         # Update docker default settings from image name
-        if build['image'] in settings.DOCKER_IMAGE_SETTINGS:
-            self.env_config.update(settings.DOCKER_IMAGE_SETTINGS[build['image']])
+        if build['image'] in settings.RTD_DOCKER_IMAGE_SETTINGS:
+            self.env_config.update(settings.RTD_DOCKER_IMAGE_SETTINGS[build['image']])
 
         # Allow to override specific project
         config_image = self.defaults.get('build_image')
@@ -700,7 +700,7 @@ def validate_build(self):
         with self.catch_validation_error('build.image'):
             image = self.pop_config('build.image', self.default_build_image)
             build['image'] = '{}:{}'.format(
-                settings.DOCKER_DEFAULT_IMAGE,
+                settings.RTD_DOCKER_DEFAULT_IMAGE,
                 validate_choice(
                     image,
                     self.valid_build_images,

readthedocs/doc_builder/constants.py

@@ -13,20 +13,20 @@
 PDF_RE = re.compile('Output written on (.*?)')
 
 # Docker
-DOCKER_SOCKET = settings.DOCKER_SOCKET
-DOCKER_VERSION = settings.DOCKER_VERSION
-DOCKER_IMAGE = settings.DOCKER_IMAGE
-DOCKER_IMAGE_SETTINGS = settings.DOCKER_IMAGE_SETTINGS
+DOCKER_SOCKET = settings.RTD_DOCKER_SOCKET
+DOCKER_VERSION = settings.RTD_DOCKER_VERSION
+DOCKER_IMAGE = settings.RTD_DOCKER_IMAGE
+DOCKER_IMAGE_SETTINGS = settings.RTD_DOCKER_IMAGE_SETTINGS
 
-old_config = settings.DOCKER_BUILD_IMAGES
+old_config = settings.RTD_DOCKER_BUILD_IMAGES
 if old_config:
     log.warning(
         'Old config detected, DOCKER_BUILD_IMAGES->DOCKER_IMAGE_SETTINGS',
     )
     DOCKER_IMAGE_SETTINGS.update(old_config)
 
 DOCKER_LIMITS = {'memory': '200m', 'time': 600}
-DOCKER_LIMITS.update(settings.DOCKER_LIMITS)
+DOCKER_LIMITS.update(settings.RTD_DOCKER_LIMITS)
 
 DOCKER_TIMEOUT_EXIT_CODE = 42
 DOCKER_OOM_EXIT_CODE = 137

readthedocs/projects/models.py

@@ -852,7 +852,7 @@ def repo_nonblockinglock(self, version, max_lock_age=None):
         if max_lock_age is None:
             max_lock_age = (
                 self.container_time_limit or
-                settings.DOCKER_LIMITS.get('time') or
+                settings.RTD_DOCKER_LIMITS.get('time') or
                 settings.REPO_LOCK_SECONDS
             )
 

readthedocs/projects/tasks.py

@@ -380,7 +380,7 @@ def run(
         """
         try:
             if docker is None:
-                docker = settings.DOCKER_ENABLE
+                docker = settings.RTD_DOCKER_ENABLE
             self.version = self.get_version(version_pk)
             self.project = self.version.project
             self.build = self.get_build(build_pk)

readthedocs/settings/base.py

@@ -335,16 +335,16 @@ def USE_PROMOS(self):  # noqa
     SENTRY_CELERY_IGNORE_EXPECTED = True
 
     # Docker
-    DOCKER_ENABLE = False
-    DOCKER_SOCKET = 'unix:///var/run/docker.sock'
+    RTD_DOCKER_ENABLE = False
+    RTD_DOCKER_SOCKET = 'unix:///var/run/docker.sock'
     # This settings has been deprecated in favor of DOCKER_IMAGE_SETTINGS
-    DOCKER_BUILD_IMAGES = None
-    DOCKER_LIMITS = {'memory': '200m', 'time': 600}
-    DOCKER_DEFAULT_IMAGE = 'readthedocs/build'
-    DOCKER_VERSION = 'auto'
-    DOCKER_DEFAULT_VERSION = 'latest'
-    DOCKER_IMAGE = '{}:{}'.format(DOCKER_DEFAULT_IMAGE, DOCKER_DEFAULT_VERSION)
-    DOCKER_IMAGE_SETTINGS = {
+    RTD_DOCKER_BUILD_IMAGES = None
+    RTD_DOCKER_LIMITS = {'memory': '200m', 'time': 600}
+    RTD_DOCKER_DEFAULT_IMAGE = 'readthedocs/build'
+    RTD_DOCKER_VERSION = 'auto'
+    RTD_DOCKER_DEFAULT_VERSION = 'latest'
+    RTD_DOCKER_IMAGE = '{}:{}'.format(RTD_DOCKER_DEFAULT_IMAGE, RTD_DOCKER_DEFAULT_VERSION)
+    RTD_DOCKER_IMAGE_SETTINGS = {
         'readthedocs/build:1.0': {
             'python': {'supported_versions': [2, 2.7, 3, 3.4]},
         },
@@ -363,9 +363,9 @@ def USE_PROMOS(self):  # noqa
     }
 
     # Alias tagged via ``docker tag`` on the build servers
-    DOCKER_IMAGE_SETTINGS.update({
-        'readthedocs/build:stable': DOCKER_IMAGE_SETTINGS.get('readthedocs/build:4.0'),
-        'readthedocs/build:latest': DOCKER_IMAGE_SETTINGS.get('readthedocs/build:5.0'),
+    RTD_DOCKER_IMAGE_SETTINGS.update({
+        'readthedocs/build:stable': RTD_DOCKER_IMAGE_SETTINGS.get('readthedocs/build:4.0'),
+        'readthedocs/build:latest': RTD_DOCKER_IMAGE_SETTINGS.get('readthedocs/build:5.0'),
     })
 
     # All auth