Show the count of the matching inactive versions

- Only show if the number exceeds the displayed number

Author: davidfischer

readthedocs/projects/views/public.py

@@ -385,6 +385,7 @@ def project_versions(request, project_slug):
     version_filter = request.GET.get('version_filter', '')
     if version_filter:
         inactive_versions = inactive_versions.filter(verbose_name__icontains=version_filter)
+    total_inactive_versions_count = inactive_versions.count()
     inactive_versions = inactive_versions[:max_inactive_versions]
 
     # If there's a wiped query string, check the string against the versions
@@ -406,6 +407,7 @@ def project_versions(request, project_slug):
             'active_versions': active_versions,
             'project': project,
             'max_inactive_versions': max_inactive_versions,
+            'total_inactive_versions_count': total_inactive_versions_count,
         },
     )
 

readthedocs/templates/projects/project_version_list.html

@@ -83,7 +83,6 @@ <h1>{% trans "Activate a version" %}</h1>
           </div>
 
           {# Version search #}
-          <a name="version-filter"></a>
           <div class="wide-search-bar">
             <div class="wide-search-bar-wrapper clearfix">
               <form action="." method="GET">
@@ -140,10 +139,10 @@ <h1>{% trans "Activate a version" %}</h1>
       </div>
     </div>
 
-    {% if inactive_versions|length >= max_inactive_versions %}
+    {% if total_inactive_versions_count > max_inactive_versions %}
       <p>
         {% blocktrans trimmed %}
-          Only the first {{ max_inactive_versions }} inactive versions were shown. Please <a href="#version-filter">filter the list</a>.
+          Showing the first {{ max_inactive_versions }} of {{ total_inactive_versions_count }} inactive versions.</a>.
         {% endblocktrans %}
       </p>
     {% endif %}