Skip to content

Commit cf38ce2

Browse files
authored
Merge pull request #7758 from readthedocs/remove-absolute-uri
Footer: remove absolute_uri
2 parents cc6cda4 + f350ff7 commit cf38ce2

File tree

4 files changed

+4
-7
lines changed

4 files changed

+4
-7
lines changed

readthedocs/api/v2/views/footer_views.py

+2-3
Original file line numberDiff line numberDiff line change
@@ -88,9 +88,8 @@ class BaseFooterHTML(APIView):
8888
8989
- project
9090
- version
91-
- page: Sphinx's page name, used for path operations,
92-
like change between languages (deprecated in favor of ``absolute_uri``).
93-
- absolute_uri: Full path with domain, used for path operations.
91+
- page: Sphinx's page name (name of the source file),
92+
used to build the "edit on" links.
9493
- theme: Used to decide how to integrate the flyout menu.
9594
- docroot: Path where all the source documents are.
9695
Used to build the ``edit_on`` URL.

readthedocs/core/static-src/core/js/doc-embed/footer.js

-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ function init() {
4444
project: rtd['project'],
4545
version: rtd['version'],
4646
page: rtd['page'],
47-
absolute_uri: window.location.href,
4847
theme: rtd.get_theme_name(),
4948
format: "jsonp",
5049
};

readthedocs/core/static/core/js/readthedocs-doc-embed.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

readthedocs/rtd_tests/tests/test_footer.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -448,8 +448,7 @@ def setUp(self):
448448

449449
self.url = (
450450
reverse('footer_html') +
451-
f'?project={self.pip.slug}&version={self.latest.slug}&page=index&docroot=/docs/' +
452-
'&absolute_uri=https://pip.readthedocs.io/en/latest/index.html'
451+
f'?project={self.pip.slug}&version={self.latest.slug}&page=index&docroot=/docs/'
453452
)
454453
self.host = 'pip.readthedocs.io'
455454

0 commit comments

Comments
 (0)