Skip to content

Commit cd6e821

Browse files
authored
Merge pull request #4976 from dojutsu-user/remove-deprecated-urlresolvers
Remove deprecated imports from "urlresolvers"
2 parents 863cb91 + 81ee2ae commit cd6e821

28 files changed

+44
-35
lines changed

readthedocs/builds/views.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
from builtins import object
1515
from django.contrib.auth.decorators import login_required
16-
from django.core.urlresolvers import reverse
16+
from django.urls import reverse
1717
from django.http import (
1818
HttpResponseForbidden,
1919
HttpResponsePermanentRedirect,

readthedocs/core/middleware.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
from django.contrib.sessions.middleware import SessionMiddleware
1010
from django.core.cache import cache
1111
from django.core.exceptions import MultipleObjectsReturned, ObjectDoesNotExist
12-
from django.core.urlresolvers import get_urlconf, set_urlconf
12+
from django.urls.base import get_urlconf, set_urlconf
1313
from django.http import Http404, HttpResponseBadRequest
1414
from django.utils.deprecation import MiddlewareMixin
1515
from django.utils.translation import ugettext_lazy as _

readthedocs/gold/views.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,17 @@
22
"""Gold subscription views."""
33

44
from __future__ import (
5-
absolute_import, division, print_function, unicode_literals)
5+
absolute_import,
6+
division,
7+
print_function,
8+
unicode_literals
9+
)
610

711
from django.conf import settings
812
from django.contrib import messages
913
from django.contrib.auth.decorators import login_required
1014
from django.contrib.messages.views import SuccessMessageMixin
11-
from django.core.urlresolvers import reverse, reverse_lazy
15+
from django.urls import reverse, reverse_lazy
1216
from django.http import HttpResponseRedirect
1317
from django.shortcuts import get_object_or_404, render
1418
from django.utils.translation import ugettext_lazy as _

readthedocs/integrations/admin.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
from __future__ import absolute_import
44
from django.contrib import admin
5-
from django.core import urlresolvers
5+
from django import urls
66
from django.utils.safestring import mark_safe
77
from pygments.formatters import HtmlFormatter
88

@@ -96,7 +96,7 @@ def exchanges(self, obj):
9696
JSONField doesn't do well with fieldsets for whatever reason. This is
9797
just to link to the exchanges.
9898
"""
99-
url = urlresolvers.reverse('admin:{0}_{1}_changelist'.format(
99+
url = urls.reverse('admin:{0}_{1}_changelist'.format(
100100
HttpExchange._meta.app_label, # pylint: disable=protected-access
101101
HttpExchange._meta.model_name, # pylint: disable=protected-access
102102
))

readthedocs/oauth/models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
from allauth.socialaccount.models import SocialAccount
1111
from django.conf import settings
1212
from django.contrib.auth.models import User
13-
from django.core.urlresolvers import reverse
13+
from django.urls import reverse
1414
from django.core.validators import URLValidator
1515
from django.db import models
1616
from django.db.models import Q

readthedocs/oauth/notifications.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# -*- coding: utf-8 -*-
22
from __future__ import division, print_function, unicode_literals
33

4-
from django.core.urlresolvers import reverse
4+
from django.urls import reverse
55
from django.utils.translation import ugettext_lazy as _
66
from messages_extends.constants import ERROR_PERSISTENT
77

readthedocs/oauth/services/bitbucket.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
import re
88

99
from django.conf import settings
10-
from django.core.urlresolvers import reverse
10+
from django.urls import reverse
1111
from requests.exceptions import RequestException
1212
from allauth.socialaccount.providers.bitbucket_oauth2.views import (
1313
BitbucketOAuth2Adapter)

readthedocs/oauth/services/github.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
import re
88

99
from django.conf import settings
10-
from django.core.urlresolvers import reverse
10+
from django.urls import reverse
1111
from requests.exceptions import RequestException
1212
from allauth.socialaccount.models import SocialToken
1313
from allauth.socialaccount.providers.github.views import GitHubOAuth2Adapter

readthedocs/oauth/services/gitlab.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
from allauth.socialaccount.providers.gitlab.views import GitLabOAuth2Adapter
1111
from django.conf import settings
12-
from django.core.urlresolvers import reverse
12+
from django.urls import reverse
1313
from requests.exceptions import RequestException
1414

1515
from readthedocs.builds.utils import get_gitlab_username_repo

readthedocs/profiles/views.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
from django.contrib.auth import logout
1313
from django.contrib.auth.decorators import login_required
1414
from django.contrib.auth.models import User
15-
from django.core.urlresolvers import reverse
15+
from django.urls import reverse
1616
from django.http import HttpResponseRedirect
1717
from django.shortcuts import get_object_or_404, redirect, render
1818
from django.utils.translation import ugettext_lazy as _

readthedocs/projects/models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
from django.conf import settings
1313
from django.contrib.auth.models import User
14-
from django.core.urlresolvers import NoReverseMatch, reverse
14+
from django.urls import NoReverseMatch, reverse
1515
from django.db import models
1616
from django.utils.encoding import python_2_unicode_compatible
1717
from django.utils.translation import ugettext_lazy as _

readthedocs/projects/tasks.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
from builtins import str
2727
from celery.exceptions import SoftTimeLimitExceeded
2828
from django.conf import settings
29-
from django.core.urlresolvers import reverse
29+
from django.urls import reverse
3030
from django.db.models import Q
3131
from django.utils import timezone
3232
from django.utils.translation import ugettext_lazy as _

readthedocs/projects/views/base.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
from datetime import timedelta
99

1010
from django.conf import settings
11-
from django.core.urlresolvers import reverse
11+
from django.urls import reverse
1212
from django.http import HttpResponseRedirect
1313
from django.shortcuts import get_object_or_404
1414
from django.utils import timezone

readthedocs/projects/views/private.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
from django.contrib import messages
1717
from django.contrib.auth.decorators import login_required
1818
from django.contrib.auth.models import User
19-
from django.core.urlresolvers import reverse
19+
from django.urls import reverse
2020
from django.http import (
2121
Http404,
2222
HttpResponseBadRequest,

readthedocs/projects/views/public.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
from django.contrib import messages
1717
from django.contrib.auth.models import User
1818
from django.core.cache import cache
19-
from django.core.urlresolvers import reverse
19+
from django.urls import reverse
2020
from django.http import Http404, HttpResponse, HttpResponseRedirect
2121
from django.shortcuts import get_object_or_404, render
2222
from django.views.decorators.cache import never_cache

readthedocs/restapi/views/task_views.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
import logging
1111

12-
from django.core.urlresolvers import reverse
12+
from django.urls import reverse
1313
from redis import ConnectionError
1414
from rest_framework import decorators, permissions
1515
from rest_framework.renderers import JSONRenderer

readthedocs/rtd_tests/tests/projects/test_admin_actions.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import django_dynamic_fixture as fixture
33
from django.contrib.admin.helpers import ACTION_CHECKBOX_NAME
44
from django.contrib.auth.models import User
5-
from django.core import urlresolvers
5+
from django import urls
66
from django.test import TestCase
77

88
from readthedocs.core.models import UserProfile
@@ -33,7 +33,7 @@ def test_project_ban_owner(self):
3333
'index': 0,
3434
}
3535
resp = self.client.post(
36-
urlresolvers.reverse('admin:projects_project_changelist'),
36+
urls.reverse('admin:projects_project_changelist'),
3737
action_data
3838
)
3939
self.assertTrue(self.project.users.filter(profile__banned=True).exists())
@@ -51,7 +51,7 @@ def test_project_ban_multiple_owners(self):
5151
'index': 0,
5252
}
5353
resp = self.client.post(
54-
urlresolvers.reverse('admin:projects_project_changelist'),
54+
urls.reverse('admin:projects_project_changelist'),
5555
action_data
5656
)
5757
self.assertFalse(self.project.users.filter(profile__banned=True).exists())
@@ -68,7 +68,7 @@ def test_project_delete(self, broadcast):
6868
'post': 'yes',
6969
}
7070
resp = self.client.post(
71-
urlresolvers.reverse('admin:projects_project_changelist'),
71+
urls.reverse('admin:projects_project_changelist'),
7272
action_data
7373
)
7474
self.assertFalse(Project.objects.filter(pk=self.project.pk).exists())

readthedocs/rtd_tests/tests/test_api.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
from allauth.socialaccount.models import SocialAccount
1515
from builtins import str
1616
from django.contrib.auth.models import User
17-
from django.core.urlresolvers import reverse
17+
from django.urls import reverse
1818
from django.http import QueryDict
1919
from django.test import TestCase
2020
from django.utils import six

readthedocs/rtd_tests/tests/test_gold.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
from __future__ import absolute_import
2-
from django.core.urlresolvers import reverse
2+
3+
from django.urls import reverse
34
from django.test import TestCase
45

56
from django_dynamic_fixture import get, fixture

readthedocs/rtd_tests/tests/test_middleware.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
from django.http import Http404
66
from django.conf import settings
77
from django.core.cache import cache
8-
from django.core.urlresolvers import get_urlconf, set_urlconf
8+
from django.urls.base import get_urlconf, set_urlconf
99
from django.test import TestCase
1010
from django.test.client import RequestFactory
1111
from django.test.utils import override_settings

readthedocs/rtd_tests/tests/test_privacy_urls.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
from builtins import object
77
from django.contrib.admindocs.views import extract_views_from_urlpatterns
88
from django.test import TestCase
9-
from django.core.urlresolvers import reverse
9+
from django.urls import reverse
1010
from django_dynamic_fixture import get
1111
import mock
1212
from taggit.models import Tag

readthedocs/rtd_tests/tests/test_profile_views.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
from __future__ import division, print_function, unicode_literals
22

33
from django.contrib.auth.models import User
4-
from django.core.urlresolvers import reverse
4+
from django.urls import reverse
55
from django.test import TestCase
66
from django_dynamic_fixture import get
77

readthedocs/rtd_tests/tests/test_project_symlinks.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
import mock
1010
from django.conf import settings
11-
from django.core.urlresolvers import reverse
11+
from django.urls import reverse
1212
from django.test import TestCase, override_settings
1313
from django_dynamic_fixture import get
1414

readthedocs/rtd_tests/tests/test_project_views.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
from django.test import TestCase
77
from django.contrib.auth.models import User
88
from django.contrib.messages import constants as message_const
9-
from django.core.urlresolvers import reverse
9+
from django.urls import reverse
1010
from django.http.response import HttpResponseRedirect
1111
from django.views.generic.base import ContextMixin
1212
from django.utils import timezone

readthedocs/rtd_tests/tests/test_sync_versions.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,16 @@
11
# -*- coding: utf-8 -*-
22

33
from __future__ import (
4-
absolute_import, division, print_function, unicode_literals)
4+
absolute_import,
5+
division,
6+
print_function,
7+
unicode_literals
8+
)
59

610
import json
711

812
from django.test import TestCase
9-
from django.core.urlresolvers import reverse
13+
from django.urls import reverse
1014
import pytest
1115

1216
from readthedocs.builds.constants import BRANCH, STABLE, TAG

readthedocs/rtd_tests/tests/test_urls.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
from __future__ import absolute_import
2-
from django.core.urlresolvers import reverse
3-
from django.core.urlresolvers import NoReverseMatch
2+
3+
from django.urls import reverse, NoReverseMatch
44
from django.test import TestCase
55

66

readthedocs/rtd_tests/tests/test_views.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
import mock
1010
from django.contrib.auth.models import User
11-
from django.core.urlresolvers import reverse
11+
from django.urls import reverse
1212
from django.test import TestCase
1313
from django.utils.six.moves.urllib.parse import urlsplit
1414
from django_dynamic_fixture import get, new

readthedocs/search/tests/test_views.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import pytest
44
from django.core.management import call_command
5-
from django.core.urlresolvers import reverse_lazy
5+
from django.urls import reverse_lazy
66
from django_dynamic_fixture import G
77
from pyquery import PyQuery as pq
88

0 commit comments

Comments
 (0)