Merge pull request #4780 from rtfd/humitos/import/notslug

Validate the slug generated is valid before importing a project

Author: humitos

readthedocs/projects/forms.py

@@ -118,6 +118,12 @@ def clean_name(self):
             if Project.objects.filter(slug=potential_slug).exists():
                 raise forms.ValidationError(
                     _('Invalid project name, a project already exists with that name'))  # yapf: disable # noqa
+            if not potential_slug:
+                # Check the generated slug won't be empty
+                raise forms.ValidationError(
+                    _('Invalid project name'),
+                )
+
         return name
 
     def clean_remote_repository(self):

readthedocs/projects/models.py

@@ -316,7 +316,7 @@ def save(self, *args, **kwargs):  # pylint: disable=arguments-differ
         if not self.slug:
             # Subdomains can't have underscores in them.
             self.slug = slugify(self.name)
-            if self.slug == '':
+            if not self.slug:
                 raise Exception(_('Model must have slug'))
         if self.documentation_type == 'auto':
             # This used to determine the type and automatically set the

readthedocs/rtd_tests/tests/test_project_forms.py

@@ -93,6 +93,16 @@ def test_import_repo_url(self):
                 form = ProjectBasicsForm(initial)
                 self.assertEqual(form.is_valid(), valid, msg=url)
 
+    def test_empty_slug(self):
+        initial = {
+            'name': "''",
+            'repo_type': 'git',
+            'repo': 'https://github.com/user/repository',
+        }
+        form = ProjectBasicsForm(initial)
+        self.assertFalse(form.is_valid())
+        self.assertIn('name', form.errors)
+
 
 class TestTranslationForms(TestCase):