Skip to content

Commit c5da4da

Browse files
committed
Throw an exception from Celery retry()
Without an exception here, or handling the return from `_check_concurrency_limit`, a build that hits a concurrency limit in this method will both set a retry on the task, but will also continue processing the current task like normal. This results in two identical builds, then three, then four, and so on. Untested what this does to the UI though.
1 parent ebca8e0 commit c5da4da

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

readthedocs/projects/tasks/builds.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,6 @@ def _check_concurrency_limit(self):
276276
})
277277
self.retry(
278278
exc=BuildMaxConcurrencyError,
279-
throw=False,
280279
# We want to retry this build more times
281280
max_retries=25,
282281
)

0 commit comments

Comments
 (0)