Skip to content

Commit c44f039

Browse files
committed
Rename method and make argument a kwarg
1 parent d1fc369 commit c44f039

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

readthedocs/api/v3/views.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ def perform_create(self, serializer):
204204
the database.
205205
"""
206206
project = serializer.save()
207-
self.import_project(project, [], self.request)
207+
self.finish_import_project(self.request, project)
208208

209209
@action(detail=True, methods=['get'])
210210
def superproject(self, request, project_slug):

readthedocs/projects/views/mixins.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ class ProjectImportMixin:
5353

5454
"""Helpers to import a Project."""
5555

56-
def import_project(self, project, tags, request):
56+
def finish_import_project(self, request, project, tags=None):
5757
"""
5858
Import a Project into Read the Docs.
5959
@@ -62,6 +62,9 @@ def import_project(self, project, tags, request):
6262
- Send Django Signal
6363
- Trigger initial build
6464
"""
65+
if not tags:
66+
tags = []
67+
6568
project.users.add(request.user)
6669
for tag in tags:
6770
project.tags.add(tag)

readthedocs/projects/views/private.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ def done(self, form_list, **kwargs):
266266
setattr(project, field, value)
267267
project.save()
268268

269-
self.import_project(project, tags, self.request)
269+
self.finish_import_project(self.request, project, tags)
270270

271271
return HttpResponseRedirect(
272272
reverse('projects_detail', args=[project.slug]),

0 commit comments

Comments
 (0)