Skip to content

Commit c3d6ee2

Browse files
humitosagjohnson
andauthored
Build: pin pip as workaround (#8865)
* Build: pin pip as workaround Latest pip version is failing wit ``` ERROR: Exception: Traceback (most recent call last): File "/home/docs/checkouts/readthedocs.org/user_builds/qtile/envs/3274/lib/python3.7/site-packages/pip/_internal/cli/base_command.py", line 165, in exc_logging_wrapper status = run_func(*args) File "/home/docs/checkouts/readthedocs.org/user_builds/qtile/envs/3274/lib/python3.7/site-packages/pip/_internal/cli/req_command.py", line 205, in wrapper return func(self, options, args) File "/home/docs/checkouts/readthedocs.org/user_builds/qtile/envs/3274/lib/python3.7/site-packages/pip/_internal/commands/install.py", line 389, in run to_install = resolver.get_installation_order(requirement_set) File "/home/docs/checkouts/readthedocs.org/user_builds/qtile/envs/3274/lib/python3.7/site-packages/pip/_internal/resolution/resolvelib/resolver.py", line 190, in get_installation_order expected_node_count=len(self._result.mapping) + 1, File "/home/docs/checkouts/readthedocs.org/user_builds/qtile/envs/3274/lib/python3.7/site-packages/pip/_internal/resolution/resolvelib/resolver.py", line 276, in get_topological_weights assert len(weights) == expected_node_count AssertionError ``` By pining it to the previous version we can make builds to workaround this issue and keep building docs successfully. See #8864 * Change pip selector to `<=` to support py27 Co-authored-by: Anthony <[email protected]>
1 parent a2e6a4a commit c3d6ee2

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

readthedocs/doc_builder/python_environments.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -471,7 +471,13 @@ def install_core_requirements(self):
471471
Feature.DONT_INSTALL_LATEST_PIP,
472472
# 20.3 uses the new resolver by default.
473473
positive='pip<20.3',
474-
negative='pip',
474+
475+
# We are pinning pip to 21.3.1 because builds are failing when
476+
# using a newer version. This is a temporal workaround to avoid
477+
# builds failing at this step, but we should come back to this and
478+
# unpin pip for this case.
479+
# https://github.com/readthedocs/readthedocs.org/issues/8864#issuecomment-1025499598
480+
negative='pip<=21.3.1',
475481
)
476482
cmd = pip_install_cmd + [pip_version, 'setuptools<58.3.0']
477483
self.build_env.run(

0 commit comments

Comments
 (0)