Merge branch 'humitos/async/initial-build' of github.com:rtfd/readthedocs.org into humitos/async/initial-build

Author: humitos

readthedocs/projects/signals.py

@@ -4,6 +4,7 @@
 import django.dispatch
 from django.dispatch import receiver
 
+from readthedocs.core.utils import trigger_build
 from readthedocs.oauth.utils import attach_webhook
 
 
@@ -23,3 +24,10 @@ def handle_project_import(sender, **kwargs):
     request = kwargs.get('request')
 
     attach_webhook(project=project, request=request)
+
+
+# TODO: move this to ImportWizardView.trigger_initial_build
+# @receiver(project_import)
+# def trigger_initial_build(sender, request, **kwargs):
+#     project = sender
+#     trigger_build(project)

readthedocs/projects/views/private.py

@@ -232,7 +232,11 @@ def done(self, form_list, **kwargs):
             if field in extra_fields:
                 setattr(project, field, value)
         project.save()
+
+        # TODO: if we want to make the ``attach_webhook`` async, we need to
+        # consider the message shown to the user when not valid webhook.
         project_import.send(sender=project, request=self.request)
+
         self.trigger_initial_build(project)
         return HttpResponseRedirect(
             reverse('projects_detail', args=[project.slug]))

readthedocs/settings/dev.py

@@ -36,6 +36,7 @@ def DATABASES(self):  # noqa
     CELERY_RESULT_BACKEND = 'redis://localhost:6379/0'
     CELERY_RESULT_SERIALIZER = 'json'
     CELERY_ALWAYS_EAGER = True
+    CELERY_TASK_IGNORE_RESULT = False
 
     EMAIL_BACKEND = 'django.core.mail.backends.console.EmailBackend'
     FILE_SYNCER = 'readthedocs.builds.syncers.LocalSyncer'